Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decision command struct #155

Merged
merged 12 commits into from
Oct 23, 2023
Merged

Decision command struct #155

merged 12 commits into from
Oct 23, 2023

Conversation

SubwayMan
Copy link
Contributor

No description provided.

Copy link
Collaborator

@Xierumeng Xierumeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed.

modules/decision_command.py Show resolved Hide resolved
modules/decision_command.py Outdated Show resolved Hide resolved
modules/decision_command.py Outdated Show resolved Hide resolved
modules/decision_command.py Outdated Show resolved Hide resolved
modules/decision_command.py Outdated Show resolved Hide resolved
modules/decision_command.py Outdated Show resolved Hide resolved
modules/decision_command.py Outdated Show resolved Hide resolved
modules/decision_command.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Xierumeng Xierumeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed.

modules/decision_command.py Outdated Show resolved Hide resolved
modules/decision_command.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Xierumeng Xierumeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditionally approved.

modules/decision_command.py Outdated Show resolved Hide resolved
@SubwayMan SubwayMan merged commit 3985f96 into main Oct 23, 2023
1 check passed
@SubwayMan SubwayMan deleted the decision_command_struct branch October 23, 2023 14:12
TongguangZhang pushed a commit that referenced this pull request Nov 24, 2023
* Initialized file with bootcamp code

* Renamed and modified functions to match list from asana, adjusted data
storage and parameters

* added z axis to command struct

* changed documentation and docstrings

* Renamed class to DecisionCommand

* added relative landing command

* modified docstrings and command parameter names

* Updated all coordinate command descriptions with NED

* PR fixes: fixed argument indentation and corrected small docstring mistake

* removed extraneous newline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants