Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conversion between local space and global space #154

Merged
merged 6 commits into from
Oct 24, 2023
Merged

Conversion between local space and global space #154

merged 6 commits into from
Oct 24, 2023

Conversation

Xierumeng
Copy link
Collaborator

Conversion between local space (NED metres) and global space (WGS 84).

@Xierumeng Xierumeng changed the title Conversion of local space and global space Conversion between local space and global space Oct 16, 2023
antholuo
antholuo reviewed Oct 20, 2023
View reviewed changes
Copy link
Member

@antholuo antholuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major comments or concerns - only on style & some questions.

modules/data_merge/data_merge_worker.py Show resolved Hide resolved
modules/data_merge/data_merge_worker.py Show resolved Hide resolved
modules/data_merge/data_merge_worker.py Show resolved Hide resolved
modules/drone_odometry_local.py Outdated Show resolved Hide resolved
modules/drone_odometry_local.py Show resolved Hide resolved
antholuo
antholuo approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@antholuo antholuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm shipppp it

@Xierumeng Xierumeng merged commit 7585640 into main Oct 24, 2023
1 check passed
@Xierumeng Xierumeng deleted the local-global-conversion branch October 24, 2023 17:43
TongguangZhang pushed a commit that referenced this pull request Nov 24, 2023
@Xierumeng @TongguangZhang
Conversion between local space and global space (#154)
f2f48f8 
* Remove home from geolocation

* Drone odometry local

* Moved conversions out and added tests

* Change unit test to hardware test

* Timeout naming

* Position may be underground
@Xierumeng Xierumeng mentioned this pull request Jan 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antholuo antholuo antholuo approved these changes

@Trotyl15 Trotyl15 Awaiting requested review from Trotyl15

@mgupta27 mgupta27 Awaiting requested review from mgupta27

@TongguangZhang TongguangZhang Awaiting requested review from TongguangZhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xierumeng @antholuo @mgupta27