New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constructor setting verification #146

Merged

ArVMal merged 24 commits into main from constructor_setting_verification

Feb 8, 2024

Contributor

ArVMal commented Aug 29, 2023

No description provided.

Xierumeng reviewed

View reviewed changes

modules/detections_and_time.py Outdated Show resolved Hide resolved

Xierumeng reviewed

View reviewed changes

modules/detections_and_time.py Show resolved Hide resolved

Xierumeng reviewed

View reviewed changes

modules/merged_odometry_detections.py Outdated Show resolved Hide resolved

Xierumeng reviewed

View reviewed changes

modules/detections_and_time.py Outdated Show resolved Hide resolved

Xierumeng reviewed

View reviewed changes

modules/merged_odometry_detections.py Outdated Show resolved Hide resolved

Xierumeng reviewed

View reviewed changes

modules/merged_odometry_detections.py Outdated Show resolved Hide resolved

Xierumeng reviewed

View reviewed changes

modules/merged_odometry_detections.py Outdated Show resolved Hide resolved

Xierumeng reviewed

View reviewed changes

modules/message_and_time.py Outdated Show resolved Hide resolved

Xierumeng reviewed

View reviewed changes

modules/merged_odometry_detections.py Outdated Show resolved Hide resolved

Xierumeng reviewed

View reviewed changes

modules/odometry_and_time.py Outdated Show resolved Hide resolved

Xierumeng reviewed

View reviewed changes

modules/odometry_and_time.py Outdated Show resolved Hide resolved

Xierumeng reviewed

View reviewed changes

modules/odometry_and_time.py Outdated Show resolved Hide resolved

Collaborator

Xierumeng commented Sep 15, 2023

Good start! Make sure to change every usage of these classes as well (you can try running python -m main_2023 ).

Does every module also follow the create() pattern?

Xierumeng reviewed

View reviewed changes

Collaborator

Xierumeng left a comment

Did you run the tests? Do they pass?

Unlike the constructor, the create() method doesn't returns just the object, it returns a tuple of bool, object . Has every caller been updated to account for this?

modules/detections_and_time.py Outdated Show resolved Hide resolved

modules/merged_odometry_detections.py Outdated Show resolved Hide resolved

Xierumeng reviewed

View reviewed changes

Collaborator

Xierumeng left a comment

Reviewed. Please also rebase branch on main/merge main into branch.

modules/detection_in_world.py Outdated Show resolved Hide resolved

modules/detections_and_time.py Outdated Show resolved Hide resolved

modules/image_and_time.py Outdated Show resolved Hide resolved

modules/object_in_world.py Outdated Show resolved Hide resolved

modules/odometry_and_time.py Outdated Show resolved Hide resolved

modules/odometry_and_time.py Outdated Show resolved Hide resolved

tests/test_geolocation_worker.py Outdated Show resolved Hide resolved

ArVMal and others added 13 commits

November 20, 2023 10:38


          Update merged_odometry_detections.py

d6779dc


          constructor verif for message_and_time

58a6cb9


          constructor verif for detections_and_time

35d2bce


          Update odometry_and_time.py

dfee2bd


          Update detections_and_time.py

f62fc18


          Update merged_odometry_detections.py

0dd1010


          Update detections_and_time.py

422a635


          Update merged_odometry_detections.py

90d3556


          Update message_and_time.py

dd6e3f2


          Update test_data_merge_worker.py

dcfe9cd


          Update test_geolocation_worker.py

8f57e7b


          updating local

c2f822c


          rebase changes

Xierumeng reviewed

View reviewed changes

Collaborator

Xierumeng left a comment

Reviewed. What happened to the other files?

modules/detections_and_time.py Outdated Show resolved Hide resolved

modules/merged_odometry_detections.py Show resolved Hide resolved


          Merge branch 'main' of https://github.com/UWARG/computer-vision-python …

a5205a8

…into constructor_setting_verification


          commit

ac66bed

ArVMal force-pushed the constructor_setting_verification branch from f482b3a to ac66bed Compare

December 6, 2023 04:48


          updated-common-submodule

c3e75c2

Xierumeng reviewed

View reviewed changes

Collaborator

Xierumeng left a comment •

edited

Loading

Reviewed. Change detect_target.py and data_merge_worker.py to support the new interface.

modules/detections_and_time.py Outdated Show resolved Hide resolved

modules/merged_odometry_detections.py Show resolved Hide resolved

modules/merged_odometry_detections.py Outdated Show resolved Hide resolved

tests/test_geolocation_worker.py Outdated Show resolved Hide resolved


          detect-target, data-merge-worker and other small changes

ca011a4

Xierumeng reviewed

View reviewed changes

Collaborator

Xierumeng left a comment

Reviewed.

modules/data_merge/data_merge_worker.py Outdated Show resolved Hide resolved

modules/data_merge/data_merge_worker.py Outdated Show resolved Hide resolved

modules/detect_target/detect_target.py Outdated Show resolved Hide resolved

Arunav added 2 commits

December 8, 2023 22:15


          small-logic-changes

dad396d


          small-logic-changes-2

e427fff

Xierumeng reviewed

View reviewed changes

Collaborator

Xierumeng left a comment

Reviewed.

modules/detect_target/detect_target.py Show resolved Hide resolved

modules/detections_and_time.py Outdated Show resolved Hide resolved

modules/merged_odometry_detections.py Outdated Show resolved Hide resolved

modules/merged_odometry_detections.py Outdated Show resolved Hide resolved

modules/merged_odometry_detections.py Outdated Show resolved Hide resolved

modules/merged_odometry_detections.py Outdated Show resolved Hide resolved

tests/test_geolocation_worker.py Outdated Show resolved Hide resolved


          removing spaces, adding an assertion

e579e7a

Xierumeng reviewed

View reviewed changes

Collaborator

Xierumeng left a comment

Reviewed.

modules/detect_target/detect_target.py Outdated Show resolved Hide resolved

modules/merged_odometry_detections.py Outdated Show resolved Hide resolved

tests/test_geolocation_worker.py Outdated Show resolved Hide resolved


          indents and space clearing

e7714fd

Xierumeng reviewed

View reviewed changes

Collaborator

Xierumeng left a comment

Reviewed.

modules/detect_target/detect_target.py Show resolved Hide resolved

tests/test_geolocation_worker.py Outdated Show resolved Hide resolved

Arunav added 3 commits

February 7, 2024 16:06


          empty-lines

ae0ac35


          Merge remote-tracking branch 'origin/main' into constructor_setting_v…

2db54f9

…erification


          merged main update

32e5223

Xierumeng approved these changes

View reviewed changes

Collaborator

Xierumeng left a comment

Approved.

ArVMal merged commit 8d5eca5 into main

1 check passed

ArVMal deleted the constructor_setting_verification branch

February 8, 2024 00:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet