-
Notifications
You must be signed in to change notification settings - Fork 942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration to pnpm and improved exports strategy #2555
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
4bbd264
Moving to pnpm as package manager. Also taking the opportunity to tid…
smallsaucepan deb837b
Changing all Turf imports to use named imports. Adding a few missing …
smallsaucepan cbefae6
Updating typescript module and moduleResolution mechanisms to "node16…
smallsaucepan 026d32f
Tweaking github workflows to explicitely install pnpm.
smallsaucepan 4cd5560
Looks like node needs the chosen cache binary installed first. Trying…
smallsaucepan 3689752
Seem to be hitting the tsx bug described here: https://github.com/pri…
smallsaucepan c94040b
Forgot to update lock file after updating tsx dep in package.json files.
smallsaucepan 0fc5e2d
Sorting modules exported from @turf/turf alphabetically. Preparatory …
smallsaucepan 89cc0c5
Converting index.mjs to typescript, and simplifying re-exported impor…
smallsaucepan 477dc61
Including tslib in @turf/turf build now that it's a TS module.
smallsaucepan afa6b2d
Lot of per-package tsconfig items now on the tsup command line, so st…
smallsaucepan effc083
Same as last commit - simplifying tsconfig.json - except these are th…
smallsaucepan faa15c8
Incorporating some suggestions from @favna on being more explicit wit…
smallsaucepan 7234245
Reapplying cjsInterop / splitting workaround for CJS exports that we …
smallsaucepan 1a9e240
Upgrading rollup and related plugins. Updating to recommended modern …
smallsaucepan d174ad3
Fluffed the browserslist config - need to cover es5 as well.
smallsaucepan f1c6358
Update .github/workflows/turf.yml to use actions/checkout v4.
smallsaucepan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
{ | ||
"npmClient": "yarn", | ||
"npmClient": "pnpm", | ||
"version": "7.0.0-alpha.2", | ||
"command": { | ||
"publish": { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,3 @@ | ||
{ | ||
"extends": "../../tsconfig.shared.json", | ||
"compilerOptions": { | ||
"outDir": "dist/js" | ||
}, | ||
"files": ["index.ts"], | ||
"extends": "../../tsconfig.shared.json" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,3 @@ | ||
{ | ||
"extends": "../../tsconfig.shared.json", | ||
"compilerOptions": { | ||
"outDir": "dist/js" | ||
}, | ||
"files": ["index.ts"] | ||
"extends": "../../tsconfig.shared.json" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,3 @@ | ||
{ | ||
"extends": "../../tsconfig.shared.json", | ||
"compilerOptions": { | ||
"outDir": "dist/js" | ||
}, | ||
"files": ["index.ts"] | ||
"extends": "../../tsconfig.shared.json" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work with .ts modules?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean "documentation lint"? Good question. I'll check and we can include turf-*/index.ts as a seperate change.