Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to pnpm and improved exports strategy #2555

Merged
merged 17 commits into from
Dec 18, 2023

Commits on Dec 10, 2023

  1. Moving to pnpm as package manager. Also taking the opportunity to tid…

    …y up our cjs / esm situation using tsup (instead of tsc and rollup). Can't get monorepolint to work with new setup so disabling for the time being.
    smallsaucepan committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    4bbd264 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. Changing all Turf imports to use named imports. Adding a few missing …

    …named exports. Updating github workflow actions to pnpm instead of yarn.
    smallsaucepan committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    deb837b View commit details
    Browse the repository at this point in the history
  2. Updating typescript module and moduleResolution mechanisms to "node16…

    …". Not tracking nodenext just yet. Changing tsup command to generate d.ts files that arethetypeswrong approves of.
    smallsaucepan committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    cbefae6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    026d32f View commit details
    Browse the repository at this point in the history
  4. Looks like node needs the chosen cache binary installed first. Trying…

    … without cache as a first step.
    smallsaucepan committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    4cd5560 View commit details
    Browse the repository at this point in the history
  5. Seem to be hitting the tsx bug described here: privatenumber/tsx#421

    …Upgrading to latest tsx to remedy.
    smallsaucepan committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    3689752 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c94040b View commit details
    Browse the repository at this point in the history
  7. Sorting modules exported from @turf/turf alphabetically. Preparatory …

    …commit to add unexported modules.
    smallsaucepan committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    0fc5e2d View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Converting index.mjs to typescript, and simplifying re-exported impor…

    …ts, and ordering alphabetically. Added in a couple of packages - convex, booleanValid and nearestNeighbourAnalysis. Rollup now only used in packages/turf so merging project root base config into there. Also now only using rollup in packages/turf to do final conversion to web module. JS and d.ts files generated the same as other modules, using tsup.
    smallsaucepan committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    89cc0c5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    477dc61 View commit details
    Browse the repository at this point in the history
  3. Lot of per-package tsconfig items now on the tsup command line, so st…

    …ripping back tsconfig.json to the bare minimum. Adding tsconfig.json to packages that while still only JS, are now processed by tsup.
    smallsaucepan committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    afa6b2d View commit details
    Browse the repository at this point in the history
  4. Same as last commit - simplifying tsconfig.json - except these are th…

    …e subset of packages that had multiple entry points e.g. 3rd party code hosted locally in lib/
    smallsaucepan committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    effc083 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2023

  1. Incorporating some suggestions from @favna on being more explicit wit…

    …h d.ts entries. Turfjs#2307 (comment)  Specifying overall module type as commonjs explicitly.
    smallsaucepan committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    faa15c8 View commit details
    Browse the repository at this point in the history
  2. Reapplying cjsInterop / splitting workaround for CJS exports that we …

    …had on build target command line earlier in this PR in to tsup config file. Also disabling treeshaking as this was generating a warning for CJS files and causing the workaround above to not work.
    smallsaucepan committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    7234245 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2023

  1. Upgrading rollup and related plugins. Updating to recommended modern …

    …browserslist config in babel.config.json e.g. previous chrome 67 and edge 17 are 5 years old, ie11 is just ... ugh
    smallsaucepan committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    1a9e240 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d174ad3 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Update .github/workflows/turf.yml to use actions/checkout v4.

    Co-authored-by: Jeroen Claassens <[email protected]>
    smallsaucepan and favna authored Dec 18, 2023
    Configuration menu
    Copy the full SHA
    f1c6358 View commit details
    Browse the repository at this point in the history