-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Adding documentations, tests, and amending algorithm for gcd_of_n_numbers.cpp #2766
Conversation
please unlink #2456 this does not fix the entirety of that issue. feel free to raise another issue with the name of the algorithm you intend to help update instead. |
on a side note is this for hacktober fest so i can label it as such |
Hi yes this is for Hacktoberfest. Thank you :) |
Reformatting code, comment and test cases, change array data type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lint this file using clang tidy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Thank you for you're contribution. A very well written pr. I will leave this up and if there is no objections will merge in a few days. Best wishes for the rest of hacktoberfest |
Thanks! |
Description of Change
Adding documentations, tests, and amending the algorithm to align with current guidelines.
Checklist
Notes:
The current algorithm is not accurate and also does not account for 0 in the array, especially when GCD is undefined if all elements are 0.