-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:申请加入用户组时,二级资源拥有者离职,上升到一级管理员审批 #2838
Open
yunlong098
wants to merge
13
commits into
TencentBlueKing:develop
Choose a base branch
from
yunlong098:feat/approver_up
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+24
−1
Open
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
2c298d4
Merge pull request #2777 from TencentBlueKing/develop
nannan00 12cc4e3
Merge pull request #2786 from TencentBlueKing/develop
nannan00 ed664a8
Merge pull request #2790 from TencentBlueKing/develop
nannan00 a4d8470
Merge pull request #2798 from TencentBlueKing/develop
nannan00 b6f6e4d
Merge pull request #2807 from TencentBlueKing/develop
nannan00 7e7cfb3
Merge pull request #2812 from TencentBlueKing/develop
nannan00 0444851
Merge pull request #2816 from TencentBlueKing/develop
nannan00 b6ebbfe
Merge pull request #2824 from TencentBlueKing/develop
nannan00 6d71d6e
Merge pull request #2830 from TencentBlueKing/develop
nannan00 953c864
feat:申请加入用户组时,二级资源拥有者离职,上升到一级管理员审批
yunlong098 cab3aba
fix:解决flake8校验失败
yunlong098 1c1bb42
Merge branch 'TencentBlueKing:master' into feat/approver_up
yunlong098 54c7530
Merge branch 'develop' into feat/approver_up
yunlong098 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不应该将 “查询不到就查询父级管理员的逻辑” 放到 svc 层面,这个逻辑是业务逻辑,应该在 biz 层处理,即函数里处理
可以调用 svc 获取分级管理,判空,若为空,在获取父管理员成员
可以在 get_grade_manager_members_by_group_id 函数上添加参数,比如 fallback_to_parent_if_empty = False
需要查看调用点,如果只有一个,默认值可以是 True,如果有其他,则需要保持旧调用点不需要变动
从当前来看,svc 不需要增加任何函数