feat:申请加入用户组时，二级资源拥有者离职，上升到一级管理员审批 #2838
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yunlong098
force-pushed
the
feat/approver_up
branch
from
8ca533d to
cab3aba
Compare
nannan00
reviewed
Dec 24, 2024
| @cachedmethod(timeout=60) # 缓存1分钟 | ||
| def get_grade_or_parent_manager_members_by_group_id(self, group_id: int) -> List[str]: | ||
| """获取分级管理员，如果为空，获取父级管理员""" | ||
| return self.svc.get_role_parent_member_by_group_id(group_id) |
There was a problem hiding this comment.
不应该将 “查询不到就查询父级管理员的逻辑” 放到 svc 层面，这个逻辑是业务逻辑，应该在 biz 层处理，即函数里处理
可以调用 svc 获取分级管理，判空，若为空，在获取父管理员成员
可以在 get_grade_manager_members_by_group_id 函数上添加参数，比如 fallback_to_parent_if_empty = False
需要查看调用点，如果只有一个，默认值可以是 True，如果有其他，则需要保持旧调用点不需要变动
从当前来看，svc 不需要增加任何函数
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
变更点(Changes)
相关issues (Which issues this PR fixes)
备注(Special notes)