Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/a11y #205

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Refactor/a11y #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ee19de6
feat: :sparkles: slider lazy loading 추가
KimKwon Oct 4, 2022
2d1a82c
edit: :fire: 적절하지 않은 li 태그 수정
KimKwon Oct 4, 2022
393932e
edit: :fire: 접근성 관련 요소 수정
KimKwon Oct 4, 2022
d0ba23e
edit: :fire: 스타일 누락 수정
KimKwon Oct 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/components/ThemeSelector/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ function ThemeSelector() {
const isValidCurrentTheme = !currentTheme || typeof currentTheme === 'string';
return (
<StyledRoot>
<h4>테마별 소품샵</h4>
<h2>테마별 소품샵</h2>
<StyledElWrapper isMain={isMain}>
{isValidCurrentTheme &&
category.map((themeType) => (
Expand All @@ -44,31 +44,31 @@ const StyledRoot = styled.div`
align-self: center;
width: 100%;

& > h4 {
& > h2 {
font-weight: 700;
font-size: 3rem;
line-height: 4.3rem;
color: ${theme.colors.black2};
}

${applyMediaQuery('desktop')} {
& > h4 {
& > h2 {
font-size: 2.6rem;
line-height: 3.8rem;
}

gap: 3.8rem;
}
${applyMediaQuery('tablet')} {
& > h4 {
& > h2 {
font-size: 2rem;
line-height: 2.9rem;
}

gap: 2.7rem;
}
${applyMediaQuery('mobile')} {
& > h4 {
& > h2 {
font-size: 1.4rem;
line-height: 2rem;
}
Expand Down
2 changes: 1 addition & 1 deletion src/components/common/Banner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ function Banner(props: BannerProps) {
if (href) {
return (
<Link passHref href={href}>
<StyledBannerLink imgUrl={src} />
<StyledBannerLink aria-label={`소담 ${src}(으)로 이동하기`} imgUrl={src} />
</Link>
);
}
Expand Down
6 changes: 3 additions & 3 deletions src/components/common/Footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ const MobileFontStyle = css`
line-height: 7px;
`;

const ContactTitle = styled.div`
const ContactTitle = styled.b`
width: 7.7rem;
font-weight: 600;
font-size: 1.4rem;
Expand All @@ -116,7 +116,7 @@ const ContactTitle = styled.div`
}
`;

const ContactContent = styled.li`
const ContactContent = styled.span`
flex: 1;
list-style: none;
font-weight: 400;
Expand Down Expand Up @@ -153,7 +153,7 @@ const RightFooterWrapper = styled.div`
}
`;

const RightFooter = styled.li`
const RightFooter = styled.span`
list-style: none;
display: flex;
justify-content: space-between;
Expand Down
2 changes: 2 additions & 0 deletions src/components/common/MainSlider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ function MainSlider(props: MainSliderProps) {
prevEl: prevRef.current, // 이전 버튼
nextEl: nextRef.current, // 다음 버튼
},
lazy: true,
preloadImages: false,
pagination: {
clickable: false,
renderBullet: (index, className) =>
Expand Down
2 changes: 1 addition & 1 deletion src/components/common/Navbar/GlobalNav/Desktop.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ function GlobalNavDesktop(props: NavProps) {
<GlobalNavBar>
<LeftNav>
<Link href="/" passHref>
<Logo>
<Logo aria-label="소담 홈페이지">
<Screen wide>
<MainLogoIC />
</Screen>
Expand Down
7 changes: 6 additions & 1 deletion src/components/common/Navbar/NavSearch/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,12 @@ function NavSearch() {
<Screen wide>
<SearchICWide />
</Screen>
<input type="text" ref={searchKeywordRef} onChange={debounce(handleChangeSearch, 500)} />
<input
title="소품샵 검색"
type="text"
ref={searchKeywordRef}
onChange={debounce(handleChangeSearch, 500)}
/>
{isOpen && (
<ResultList ref={searchRef}>
{results.length > 0 ? (
Expand Down
3 changes: 2 additions & 1 deletion src/pages/_document.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export default class MyDocument extends Document {

render() {
return (
<Html>
<Html lang="ko">
<Head>
<script
type="text/javascript"
Expand All @@ -49,6 +49,7 @@ export default class MyDocument extends Document {
href="https://fonts.googleapis.com/css2?family=Noto+Sans+KR:wght@300;400;500;700&display=swap"
rel="stylesheet"
/>
<meta name="description" content="소담의 소품샵 큐레이션을 만나보세요" />
<meta property="og:title" content="소담 :: 소품샵 여정의 이야기를 담다" />
<meta property="og:description" content="소담의 소품샵 큐레이션을 만나보세요" />
<meta property="og:url" content="sodam.me" />
Expand Down