Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/a11y #205

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Refactor/a11y #205

wants to merge 4 commits into from

Conversation

KimKwon
Copy link
Member

@KimKwon KimKwon commented Oct 11, 2022

lighthouse에서 제안하는 접근성 관련 이슈들을 해결한 PR입니다.

SEO 90->100, a11y 78->95로 향상했습니다.

1. a 태그에 aria-label 추가
2. input 태그에 label을 명시적으로 추가할 것 => 하지 못한다면 title 속성은 제공하자.
3. heading 태그는 descending 한 구조로 작성하자.
4. html lang 속성을 추가하자.
393932e
위의 커밋의 수정에 따른 스타일 누락 수정
@vercel
Copy link

vercel bot commented Oct 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
sodam-client ✅ Ready (Inspect) Visit Preview Oct 11, 2022 at 7:21AM (UTC)

@netlify
Copy link

netlify bot commented Oct 11, 2022

Deploy Preview for sodam ready!

Name Link
🔨 Latest commit d0ba23e
🔍 Latest deploy log https://app.netlify.com/sites/sodam/deploys/63451986f7339e0008b86bd3
😎 Deploy Preview https://deploy-preview-205--sodam.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant