Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign ActionMenu and introduce MenuButton #591

Merged
merged 9 commits into from
Sep 13, 2023

Conversation

mattias800
Copy link
Collaborator

@mattias800 mattias800 commented Sep 11, 2023

  • Introduce MenuButton, which is a dumb UI component for buttons in the action menu, search filter, and sidebar menu.

  • Increase the border radius of Popover from 4px to 8px.

  • Update ActionMenu and ActionMenuButton popover, as per design.

  • Remove SidebarMenuCollapsible stuff that is no longer used.

  • Breaking: ActionMenu no longer supports left, right, iconRight, loading, and success.

  • Breaking: ActionMenu variants now only have standard and danger options.

image

- SidebarMenuCollapsible uses CollapsibleButton.
- Breaking: SidebarMenuLink no longer has `renderLink` prop.
- Remove SidebarMenuCollapsible stuff that is no longer used.
- MenuButton can now be disabled.
- Working on ActionMenu.
- Update ActionMenu and ActionMenuButton popover, as per design.
Breaking: ActionMenu no longer supports left, right, iconRight, loading, success.
Breaking: ActionMenu variants now only has standard and danger options.
@github-actions
Copy link

github-actions bot commented Sep 11, 2023

Size Change: 0 B

Total Size: 343 kB

ℹ️ View Unchanged
Filename Size
packages/calendar/dist/index.es.js 15.1 kB
packages/calendar/dist/index.js 13 kB
packages/core/dist/index.es.js 4.99 kB
packages/core/dist/index.js 4.68 kB
packages/elements/dist/index.es.js 103 kB
packages/elements/dist/index.js 102 kB
packages/filter/dist/index.es.js 3.76 kB
packages/filter/dist/index.js 3.27 kB
packages/forms/dist/index.es.js 6.75 kB
packages/forms/dist/index.js 6.27 kB
packages/grid-export/dist/index.es.js 2.07 kB
packages/grid-export/dist/index.js 2.02 kB
packages/grid/dist/index.es.js 16.1 kB
packages/grid/dist/index.js 13.8 kB
packages/input-mask/dist/index.es.js 804 B
packages/input-mask/dist/index.js 735 B
packages/modal/dist/index.es.js 3.03 kB
packages/modal/dist/index.js 2.85 kB
packages/panels/dist/index.es.js 8.72 kB
packages/panels/dist/index.js 8 kB
packages/redux/dist/index.es.js 3.06 kB
packages/redux/dist/index.js 2.75 kB
packages/select/dist/index.es.js 4.02 kB
packages/select/dist/index.js 3.65 kB
packages/theme/dist/index.es.js 1.9 kB
packages/theme/dist/index.js 1.96 kB
packages/tooltip/dist/index.es.js 2.91 kB
packages/tooltip/dist/index.js 2.72 kB

compressed-size-action

@mattias800 mattias800 requested review from AugustasFriend and esepato and removed request for LordDz September 11, 2023 15:48
@mattias800 mattias800 merged commit 3c52c02 into next Sep 13, 2023
2 checks passed
@mattias800 mattias800 deleted the feature/rebrand-collapsible branch September 13, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants