-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign ActionMenu and introduce MenuButton #591
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- SidebarMenuCollapsible uses CollapsibleButton.
- Breaking: SidebarMenuLink no longer has `renderLink` prop. - Remove SidebarMenuCollapsible stuff that is no longer used.
- MenuButton can now be disabled. - Working on ActionMenu.
- Update ActionMenu and ActionMenuButton popover, as per design. Breaking: ActionMenu no longer supports left, right, iconRight, loading, success. Breaking: ActionMenu variants now only has standard and danger options.
Size Change: 0 B Total Size: 343 kB ℹ️ View Unchanged
|
mattias800
requested review from
AugustasFriend and
esepato
and removed request for
LordDz
September 11, 2023 15:48
packages/elements/src/components/ui/buttons/menu-button/MenuButtonContent.tsx
Show resolved
Hide resolved
packages/elements/src/components/ui/buttons/menu-button/MenuButtonGroupBox.tsx
Show resolved
Hide resolved
AugustasFriend
approved these changes
Sep 12, 2023
mattias800
added a commit
that referenced
this pull request
Sep 13, 2023
mattias800
added a commit
that referenced
this pull request
Sep 14, 2023
mattias800
added a commit
that referenced
this pull request
Sep 14, 2023
This was referenced Sep 25, 2023
Merged
Merged
mattias800
added a commit
that referenced
this pull request
Sep 27, 2023
This was referenced Nov 3, 2023
This was referenced Nov 10, 2023
Merged
This was referenced Nov 22, 2023
Merged
Merged
Merged
This was referenced Dec 1, 2023
This was referenced Dec 8, 2023
This was referenced Dec 15, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce MenuButton, which is a dumb UI component for buttons in the action menu, search filter, and sidebar menu.
Increase the border radius of Popover from 4px to 8px.
Update ActionMenu and ActionMenuButton popover, as per design.
Remove SidebarMenuCollapsible stuff that is no longer used.
Breaking: ActionMenu no longer supports left, right, iconRight, loading, and success.
Breaking: ActionMenu variants now only have standard and danger options.