Nav bar and sidebar menu redesign #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This does not include update of collapsible.
mattias800
requested review from
lindskogen,
nikteg,
LordDz and
esepato
and removed request for
nikteg
|
Size Change: 0 B Total Size: 239 kB ℹ️ View Unchanged
|
…sible. - Breaking: Remove `indent` prop on SidebarMenuLink. Indentation is now done automatically by SidebarMenuCollapsible.
- Add Stena flag SVG in elements. - Add Stena flag in sidebar menu top. - Add state highlight to sidebar menu items when selected (not selected already had highlight). - Make heading text in sidebar menu smaller. - Add aria-expanded to SidebarMenuCollapsible.
…ove it. - Remove custom styling of heading, just using overline variant.
…ntentLeft, contentRight or custom Text props.
…ach element adding indent for itself. - Remove collapsible styling CSS, since it is not used any longer. - Items now have smaller font when in an expanded group.
- Drawer no longer gets blue outline when opening drawer with keyboard.
…orrect alignment now.
nikteg
requested changes
Sep 7, 2023
packages/panels/src/components/sidebar-menu/SidebarMenuCollapsible.tsx
Outdated
Show resolved
Hide resolved
packages/panels/src/components/sidebar-menu/SidebarMenuCollapsibleGroupBox.tsx
Outdated
Show resolved
Hide resolved
packages/panels/src/components/sidebar-menu/SidebarMenuCollapsible.tsx
Outdated
Show resolved
Hide resolved
nikteg
approved these changes
Sep 8, 2023
mattias800
added a commit
that referenced
this pull request
Sep 13, 2023
mattias800
added a commit
that referenced
this pull request
Sep 14, 2023
mattias800
added a commit
that referenced
this pull request
Sep 14, 2023
This was referenced Nov 3, 2023
This was referenced Nov 10, 2023
Merged
This was referenced Nov 22, 2023
Merged
Merged
Merged
This was referenced Dec 1, 2023
This was referenced Dec 8, 2023
This was referenced Dec 15, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not update collapsible, which is used by sidebar menu.