-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revive action primitives example and test #842
base: og-develop
Are you sure you want to change the base?
Conversation
This is a pre-step for #844 |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Changed fetch robot arm from ik controller to joint controller
Action items
Screencast from 08-26-2024 07:25:12 PM.webm |
Revived the action primitives test (symbolic primitives test wip) and examples for both Fetch and Tiago robot Fixed issues: Pending issues: |
omnigibson/action_primitives/starter_semantic_action_primitives.py
Outdated
Show resolved
Hide resolved
omnigibson/action_primitives/starter_semantic_action_primitives.py
Outdated
Show resolved
Hide resolved
omnigibson/action_primitives/starter_semantic_action_primitives.py
Outdated
Show resolved
Hide resolved
omnigibson/action_primitives/starter_semantic_action_primitives.py
Outdated
Show resolved
Hide resolved
omnigibson/action_primitives/starter_semantic_action_primitives.py
Outdated
Show resolved
Hide resolved
# TODO: wip solution for goal pose not consistent with action pose. if the controller uses delta motion, convert the no_op to all zeros | ||
if self.robot._controller_config[name].get("use_delta_commands", True): | ||
no_op_goal = {key: th.zeros_like(value) for key, value in no_op_goal.items()} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge og-develop and revert your changes here - this is already fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put this back and figure out why it wont work
omnigibson/configs/fetch_config.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the configs directory, there should be exactly ONE config PER robot (e.g. fetch_primitives, tiago_primitives) that we use for ALL primitives-related tests, examples, etc - if things need to be edited a bit for each example (e.g. add task) we should do that in code.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Prevent loading a robot with the wrong configuration upon initializing the environment