-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[choreo] Upgrade to Tauri v2 #489
base: main
Are you sure you want to change the base?
Conversation
The app has the following issues on my Linux machine:
Issue 1 is happening for me with 2024.2.2 as well, so it's probably not Tauri v2 causing it. If someone confirms neither of these issues occurs on Windows, I'm OK with merging this PR. |
3b8ce57
to
f410383
Compare
Issue 1 was reproduced on Windows but not issue 2. |
46fa6f0
to
a58b1d5
Compare
29b0888
to
f8eb257
Compare
06cf02c
to
7386e72
Compare
a06664d
to
b440e96
Compare
63df449
to
71935df
Compare
ed91bd8
to
54d007c
Compare
c4390ad
to
8a73ee0
Compare
4858e85
to
d1d7950
Compare
Keybinds dont work on my ubuntu 24.04 system but everything else seems to work |
d1d7950
to
89ca88a
Compare
Yea, I've had mixed results with the keybinds on Arch too. I also heard on the Discord that the Windows version crashes randomly. I just updated the PR to Tauri v2's official release, so we'll see if that changes anything. |
89ca88a
to
d7693fb
Compare
If we get the app running properly in Tauri v2 would we ship that for 2025? I'm personally in favor of doing so along as we properly stress test it. |
d7693fb
to
b3fd1b3
Compare
I'd say the cutoff is late November, when teams usually stop beta testing stuff. |
In addition to the flaky keyboard shortcuts, the app also doesn't exit after clicking the window close button. The window closes, but the app continues to run. I had to Ctrl-C to kill it. |
1828349
to
f978206
Compare
cb0da57
to
b9973c5
Compare
b9973c5
to
42eec7c
Compare
No description provided.