Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[choreo] Upgrade to Tauri v2 #489

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

calcmogul
Copy link
Member

No description provided.

@calcmogul
Copy link
Member Author

The app has the following issues on my Linux machine:

  1. keyboard shortcuts don't work until the window is in focus (and sometimes not even then)
  2. the file open dialog crashes if I press Escape

Issue 1 is happening for me with 2024.2.2 as well, so it's probably not Tauri v2 causing it. If someone confirms neither of these issues occurs on Windows, I'm OK with merging this PR.

@calcmogul
Copy link
Member Author

Issue 1 was reproduced on Windows but not issue 2.

@calcmogul calcmogul force-pushed the upgrade-to-tauri-v2 branch 2 times, most recently from 46fa6f0 to a58b1d5 Compare June 24, 2024 23:49
@calcmogul calcmogul force-pushed the upgrade-to-tauri-v2 branch 9 times, most recently from 29b0888 to f8eb257 Compare July 11, 2024 18:18
@calcmogul calcmogul force-pushed the upgrade-to-tauri-v2 branch 2 times, most recently from 06cf02c to 7386e72 Compare July 17, 2024 05:47
@calcmogul calcmogul force-pushed the upgrade-to-tauri-v2 branch 9 times, most recently from a06664d to b440e96 Compare August 5, 2024 06:41
@calcmogul calcmogul force-pushed the upgrade-to-tauri-v2 branch 2 times, most recently from 63df449 to 71935df Compare August 15, 2024 15:36
@calcmogul calcmogul force-pushed the upgrade-to-tauri-v2 branch 3 times, most recently from ed91bd8 to 54d007c Compare August 22, 2024 04:00
@calcmogul calcmogul force-pushed the upgrade-to-tauri-v2 branch 3 times, most recently from c4390ad to 8a73ee0 Compare September 27, 2024 06:31
@calcmogul calcmogul changed the title Upgrade to Tauri v2 [choreo] Upgrade to Tauri v2 Sep 29, 2024
@calcmogul calcmogul force-pushed the upgrade-to-tauri-v2 branch 2 times, most recently from 4858e85 to d1d7950 Compare October 1, 2024 20:47
@spacey-sooty
Copy link
Collaborator

Keybinds dont work on my ubuntu 24.04 system but everything else seems to work

@calcmogul
Copy link
Member Author

calcmogul commented Oct 2, 2024

Yea, I've had mixed results with the keybinds on Arch too. I also heard on the Discord that the Windows version crashes randomly. I just updated the PR to Tauri v2's official release, so we'll see if that changes anything.

@oh-yes-0-fps
Copy link
Collaborator

If we get the app running properly in Tauri v2 would we ship that for 2025? I'm personally in favor of doing so along as we properly stress test it.

@calcmogul
Copy link
Member Author

I'd say the cutoff is late November, when teams usually stop beta testing stuff.

@calcmogul
Copy link
Member Author

calcmogul commented Oct 3, 2024

In addition to the flaky keyboard shortcuts, the app also doesn't exit after clicking the window close button. The window closes, but the app continues to run. I had to Ctrl-C to kill it.

@calcmogul calcmogul force-pushed the upgrade-to-tauri-v2 branch 7 times, most recently from 1828349 to f978206 Compare October 11, 2024 01:32
@calcmogul calcmogul force-pushed the upgrade-to-tauri-v2 branch 7 times, most recently from cb0da57 to b9973c5 Compare October 16, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants