Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes date picker alignment and date value not showing up while editing on task details page #1260

Merged
merged 23 commits into from
Oct 4, 2024
Merged

Fixes date picker alignment and date value not showing up while editing on task details page #1260

merged 23 commits into from
Oct 4, 2024

Conversation

Ayushsanjdev
Copy link
Contributor

@Ayushsanjdev Ayushsanjdev commented Sep 15, 2024 •
edited
Loading

Date: 15-09-2024

Developer Name: Ayush Sanj

Issue Ticket Number

Description

  1. Date picker alignment issue fixed.
  2. Loader like Saving... updated after saving the task.
  3. Moved States to relevant components.
  4. Code refactor.
  5. Update relevant test cases.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1
Screen.Recording.2024-09-17.at.12.17.55.AM.mov

with extension icon:

Screen.Recording.2024-09-20.at.2.44.05.AM.mov

with feature dev flag toggle:

Screen.Recording.2024-10-04.at.9.58.49.PM.mov

Test Coverage

Screenshot 1 image image

Additional Notes

Found some states in parent component unnecessarily prop drilled which could have been used in details component. so refactored it. To show the input field, I put it in details component to be shown with isEditing + isUserAuthorised. Updated test cases for same. New addition: Saving... Loader to show on save while saving task.

@vercel Vercel
Copy link

vercel bot commented Sep 15, 2024

@Ayushsanjdev is attempting to deploy a commit to the RDS-Team Team on Vercel.

A member of the Team first needs to authorize it.

@Ayushsanjdev Ayushsanjdev marked this pull request as ready for review September 16, 2024 19:16
iamitprakash
iamitprakash previously approved these changes Sep 16, 2024
View reviewed changes
@Ayushsanjdev Ayushsanjdev marked this pull request as draft September 17, 2024 07:44
@Ayushsanjdev Ayushsanjdev marked this pull request as ready for review September 17, 2024 19:06
vinit717
vinit717 requested changes Sep 19, 2024
View reviewed changes
src/components/taskDetails/index.tsx Show resolved Hide resolved
__tests__/Unit/Components/Tasks/TaskDetails.test.tsx Outdated Show resolved Hide resolved
src/components/taskDetails/Details.tsx Show resolved Hide resolved
src/components/taskDetails/TaskHeader.tsx Outdated Show resolved Hide resolved
Achintya-Chatterjee
Achintya-Chatterjee reviewed Sep 19, 2024
View reviewed changes
Copy link
Member

@Achintya-Chatterjee Achintya-Chatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please upload a video, there should be extension link in the end date

@Ayushsanjdev
Copy link
Contributor Author

can you please upload a video, there should be extension link in the end date

Uploaded @Achintya-Chatterjee inside screenshot, please let me know any misunderstandings

@Ayushsanjdev
Copy link
Contributor Author

Ayushsanjdev commented Sep 20, 2024 •
edited
Loading

updated latest test coverage too.
@vinit717 updated changes that you asked, Please have a look, thanks!

@Ayushsanjdev
Copy link
Contributor Author

@vinit717 , refactored that nested code.

@Ayushsanjdev
Copy link
Contributor Author

@vinit717 updated test screenshot:

  • all test passed:
image

*coverage:
image

@vinit717
Copy link
Member

Reference in new issue
Edit
Hide
Delete

Can you increase index file and taskdate file test coverage

@Ayushsanjdev
Copy link
Contributor Author

Reference in new issue
Edit
Hide
Delete

Can you increase index file and taskdate file test coverage

Ok will work on it 👍

@Ayushsanjdev
Copy link
Contributor Author

Ayushsanjdev commented Sep 23, 2024 •
edited
Loading

image

Updated coverage for date test component from 50 to 100. @vinit717 , working on index file

@Ayushsanjdev
Copy link
Contributor Author

Ayushsanjdev commented Sep 29, 2024 •
edited
Loading

image image

@vinit717 updated test cases coverage ^

vinit717
vinit717 reviewed Oct 1, 2024
View reviewed changes
src/components/taskDetails/Details.tsx Outdated Show resolved Hide resolved
src/components/taskDetails/Details.tsx Outdated Show resolved Hide resolved
src/components/taskDetails/Details.tsx Outdated Show resolved Hide resolved
@vinit717
Copy link
Member

vinit717 commented Oct 2, 2024

Can you please put this feature behind feature flag

@Ayushsanjdev
Copy link
Contributor Author

@vinit717 updated feature flag

@vinit717
Copy link
Member

vinit717 commented Oct 4, 2024

Can you update the video for feature flag

@Ayushsanjdev
Copy link
Contributor Author

@vinit717 updated feature flag video in screen shot section

asharma991
asharma991 approved these changes Oct 4, 2024
View reviewed changes
Copy link

@asharma991 asharma991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shubhdevelop
shubhdevelop approved these changes Oct 4, 2024
View reviewed changes
Copy link

@shubhdevelop shubhdevelop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well

@iamitprakash iamitprakash merged commit b2743f2 into Real-Dev-Squad:develop Oct 4, 2024
1 of 2 checks passed
@vinit717 vinit717 mentioned this pull request Oct 5, 2024
Merged
10 tasks
@Ayushsanjdev Ayushsanjdev mentioned this pull request Oct 21, 2024
Merged
10 tasks
iamitprakash pushed a commit that referenced this pull request Oct 21, 2024
@Ayushsanjdev
FF removal for PR #1260 (#1275)
ab3fe2e 
* remove FF

* fix: tests
@vinit717 vinit717 mentioned this pull request Oct 23, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhdevelop shubhdevelop shubhdevelop approved these changes

@asharma991 asharma991 asharma991 approved these changes

@vinit717 vinit717 vinit717 approved these changes

@Achintya-Chatterjee Achintya-Chatterjee Achintya-Chatterjee left review comments

@iamitprakash iamitprakash Awaiting requested review from iamitprakash

Assignees

@Ayushsanjdev Ayushsanjdev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Date picker wrong alignment behaviour in dates section (for authorized users)
7 participants
@Ayushsanjdev @vinit717 @Achintya-Chatterjee @iamitprakash @shubhdevelop @asharma991 @yesyash