Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev to Main sync #1267

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Dev to Main sync #1267

merged 1 commit into from
Oct 5, 2024

Conversation

vinit717
Copy link
Member

@vinit717 vinit717 commented Oct 5, 2024

Date: 5 Oct 2024

Developer Name: Ayush Sanj (ayush-sanj-1)


Issue Ticket Number

Pr to Sync

Description

This PR fixes date picker alignment and date value not showing up while editing on task details page.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Working Video
Screen.Recording.2024-10-05.at.3.58.39.PM.mov

…ng on task details page (#1260)

* fix: date picker alignment and prefilled

* fix: test cases for dates and details

* update: test files

* refactor: detail content component

* fix: useEffect to be conditional

* Improved test coverage for taskDates

* revert back to original change

* fix: edge case of invalid date

* fix: redundancy in detailsContent

* added more restriction to date validation

* fix: test case for invalid-date

* fix: test case with await

* updated test case for failure onsave

* refactor: detailsContent

* update test case for isValidDate utils

* updated feature flag

* fix: test case name

---------

Co-authored-by: Achintya Chatterjee <[email protected]>
Co-authored-by: Yash Raj <[email protected]>
Copy link

vercel bot commented Oct 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
status-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2024 11:24am

@iamitprakash iamitprakash merged commit ebf0953 into main Oct 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants