Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update winit #422

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Update winit #422

merged 4 commits into from
Jul 29, 2024

Conversation

Ralith
Copy link
Owner

@Ralith Ralith commented Jul 28, 2024

Builds, but still needs manual testing.

@patowen
Copy link
Collaborator

patowen commented Jul 28, 2024

I was able to run this branch successfully on my Windows machine, and all the buttons still seem to work as expected.

@Ralith Ralith marked this pull request as ready for review July 28, 2024 23:44
patowen
patowen approved these changes Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@patowen patowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I left a few comments for minor things. Thanks for working on this, as it would have been very tricky for me to do.

@Ralith Ralith enabled auto-merge (rebase) July 29, 2024 00:09
@Ralith Ralith merged commit 9e04fea into master Jul 29, 2024
4 checks passed
@Ralith Ralith deleted the update-winit branch July 29, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patowen patowen patowen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ralith @patowen