Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load character entities from the save file #414

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

patowen
Copy link
Collaborator

@patowen patowen commented Jun 30, 2024

This PR sets up the initial implementation of loading entity data from a save file by loading player characters. In single-player, this has the effect of having the game remember where you were when you close it. If you change your name, you will spawn in as a new character.

The following are not currently implemented:

  • Saving client-authoritative orientation data (the orientation quaternion)
  • Only loading entities in nearby chunks (Currently, everything is loaded.)
  • Saving the inventory

@patowen patowen requested a review from Ralith June 30, 2024 21:12
server/src/sim.rs Outdated Show resolved Hide resolved
server/src/sim.rs Outdated Show resolved Hide resolved
server/src/sim.rs Outdated Show resolved Hide resolved
Copy link
Owner

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this already looks much cleaner, thanks!

common/src/proto.rs Outdated Show resolved Hide resolved
server/src/lib.rs Outdated Show resolved Hide resolved
server/src/sim.rs Outdated Show resolved Hide resolved
server/src/sim.rs Outdated Show resolved Hide resolved
server/src/sim.rs Show resolved Hide resolved
server/src/sim.rs Outdated Show resolved Hide resolved
server/src/sim.rs Show resolved Hide resolved
server/src/sim.rs Outdated Show resolved Hide resolved
@patowen
Copy link
Collaborator Author

patowen commented Jul 28, 2024

My previous update was merging the master branch and resolving merge conflicts. My next update will be handling review comments.

common/src/proto.rs Outdated Show resolved Hide resolved
@Ralith Ralith merged commit ad363cc into Ralith:master Jul 28, 2024
4 checks passed
@patowen
Copy link
Collaborator Author

patowen commented Jul 28, 2024

Thanks for reviewing/merging!

@patowen patowen deleted the load-character-entities branch July 28, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants