-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load character entities from the save file #414
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ralith
requested changes
Jun 30, 2024
patowen
force-pushed
the
load-character-entities
branch
from
July 1, 2024 01:11
79b8f89
to
3ff51f4
Compare
patowen
force-pushed
the
load-character-entities
branch
from
July 6, 2024 03:13
3ff51f4
to
eda1508
Compare
Ralith
requested changes
Jul 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this already looks much cleaner, thanks!
patowen
force-pushed
the
load-character-entities
branch
from
July 28, 2024 16:24
eda1508
to
9bf9264
Compare
My previous update was merging the master branch and resolving merge conflicts. My next update will be handling review comments. |
patowen
force-pushed
the
load-character-entities
branch
from
July 28, 2024 16:33
9bf9264
to
20df126
Compare
Ralith
approved these changes
Jul 28, 2024
patowen
force-pushed
the
load-character-entities
branch
from
July 28, 2024 18:18
20df126
to
e4d0145
Compare
Thanks for reviewing/merging! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up the initial implementation of loading entity data from a save file by loading player characters. In single-player, this has the effect of having the game remember where you were when you close it. If you change your name, you will spawn in as a new character.
The following are not currently implemented: