[photonlib] Simulation Visualization Update #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into sim-draw-targets
mcm001
approved these changes
Aug 19, 2023
|
Can we use the wpilib dev versions to use those PRs cause they were merged |
|
Send it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
2023-08-11.02-11-56_H.264_wireframe.mp4
(^ Pincushion distortion is demonstrated, but note that barrel distortion does not play well. The visualization is fairly toy-ish and not made with that in mind.)
2023-08-14.16-05-07_H.264_wireframe_smile.mp4
:]
Note:
Implementing the wireframe visualization uncovered some Java performance issues (wpilibsuite/allwpilib#5525, wpilibsuite/allwpilib#5524) which have a stopgap fix in this PR. This will need to be reverted after the wpilib fixes are merged into photon. Field wireframe is currently disabled by default.
The current loop time spent visualizing is quite long (~2 ms on my desktop including wireframe) and there are frequent GC spikes scaling with the number of targets visible. I'm struggling to get my profiler running correctly to diagnose this but it should be looked at as well after the next wpilib merge.