-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Protobuf] Make MultiTarget result optional #1024
Open
srimanachanta
wants to merge
99
commits into
PhotonVision:master
Choose a base branch
from
srimanachanta:optional-multitag-pose
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Protobuf] Make MultiTarget result optional #1024
srimanachanta
wants to merge
99
commits into
PhotonVision:master
from
srimanachanta:optional-multitag-pose
+1,371
−1,633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optional Multitarget Protobuf:
|
srimanachanta
changed the title
Make MultiTarget result optional
[Protobuf] Make MultiTarget result optional
Dec 19, 2023
needs to be rebased or is this good to close? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing an
isPresent
prop in thePNPResult
doesn't make much sense instead of just passing anOptional<PNPResult>
.Based on #974 because I am too lazy to reimplement Packet
Also combines the
ProtobufMultitargetResult
andPNPResult
messages and makesProtobufMultitargetResult
optional onProtoufPipelineResult
. This should reduce total serialization byte size as less messages need to be packed and optional saves time.