Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AT specific targeting classes and fields optional #1059

Open
srimanachanta opened this issue Dec 19, 2023 · 0 comments
Open

Make AT specific targeting classes and fields optional #1059

srimanachanta opened this issue Dec 19, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@srimanachanta
Copy link
Member

Currently, fields like bestCamToTag and the entirety of the multitagResult are dependent on the pipeline settings and are wrapped by checks of their presence either by flags or by nullability. This is incorrect and should instead be replaced by using optional accessors to these values. This should also provide a small but decent speed increase the the serde Packet functions.

Diff can be copied from #1024 and #1058. Optional logic still needs to be implemented for PhotonTrackedTarget.

@srimanachanta srimanachanta added the enhancement New feature or request label Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant