Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: rpc-proxy, xenmgr, updatemgr: Use rpc-autogen bindings module #184

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

RFC: rpc-proxy, xenmgr, updatemgr: Use rpc-autogen bindings module #184

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d6e496
rpc-proxy: Use rpc-autogen bindings module
Jun 14, 2021
e4b9991
updatemgr: Use rpc-autogen bindings module
Jun 14, 2021
3a7553a
xenmgr: Use rpc-autogen bindings module
Jun 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion rpc-proxy/rpc-proxy.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ Executable rpc-proxy
transformers-base,
xchwebsocket,
xchxenstore,
xchdb
xchdb,
rpc-autogen
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised you had to add rpc-autogen. xchdb switched to rpc-autogen in its own commit, so I would think that is sufficient. Does rpc-proxy need some other idl binding that it was receiving transitively?

I don't know cabal, so I may be totally wrong.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rpcgen does have its dbus stub generated from an xml, which is why I put the explicit dependency, but it could get the object from xchdb. I can check that.

Main-Is: Main.hs
if flag(stubdom)
GHC-Options: -O2 -fwarn-incomplete-patterns -static -optl-static -optl-pthread
Expand Down