RFC: rpc-proxy, xenmgr, updatemgr: Use rpc-autogen bindings module #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 14, 2021 18:08
dbus-gen generates a set of bindings for the currently supported API. Use the built module instead of relying on generating the bindings from the IDL in the source tree. Signed-off-by: Eric Chanudet <[email protected]>
dbus-gen generates a set of bindings for the currently supported API. Use the built module instead of relying on generating the bindings from the IDL in the source tree. Signed-off-by: Eric Chanudet <[email protected]>
dbus-gen generates a set of bindings for the currently supported API. Use the built module instead of relying on generating the bindings from the IDL in the source tree. Signed-off-by: Eric Chanudet <[email protected]>
jandryuk
reviewed
Jun 22, 2021
| @@ -38,7 +38,8 @@ Executable rpc-proxy | |||
| transformers-base, | |||
| xchwebsocket, | |||
| xchxenstore, | |||
| xchdb | |||
| xchdb, | |||
| rpc-autogen | |||
There was a problem hiding this comment.
I'm surprised you had to add rpc-autogen. xchdb switched to rpc-autogen in its own commit, so I would think that is sufficient. Does rpc-proxy need some other idl binding that it was receiving transitively?
I don't know cabal, so I may be totally wrong.
There was a problem hiding this comment.
rpcgen does have its dbus stub generated from an xml, which is why I put the explicit dependency, but it could get the object from xchdb. I can check that.
|
Oh, I didn't realize rpc-proxy implemented an idl. Your change is good in
that case.
…On Tue, Jun 22, 2021, 4:42 PM Eric Chanudet ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In rpc-proxy/rpc-proxy.cabal
<#184 (comment)>:
> @@ -38,7 +38,8 @@ Executable rpc-proxy
transformers-base,
xchwebsocket,
xchxenstore,
- xchdb
+ xchdb,
+ rpc-autogen
rpcgen does have its dbus stub generated from an xml
<https://github.com/OpenXT/idl/blob/master/interfaces/rpc_proxy.xml#L6>,
which is why I put the explicit dependency, but it could get the object
from xchdb. I can check that.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#184 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOKZPZLYBK6Z7VFWTC6V6LTUDYSRANCNFSM46YCVYRA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dbus-gen generates a set of bindings for the currently supported API. Use the built module instead of relying on generating the bindings from the IDL in the source tree.