-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backend] Share/unshare tasks should be done by creation date from olders to more recents to have correctly ordered stream events (#8843)(#9200)(#9371) #9394
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9394 +/- ##
==========================================
+ Coverage 65.34% 65.37% +0.02%
==========================================
Files 624 624
Lines 59697 59723 +26
Branches 6687 6696 +9
==========================================
+ Hits 39011 39041 +30
+ Misses 20686 20682 -4 ☔ View full report in Codecov by Sentry. |
4c550f6
to
2dce3d8
Compare
59ee949
to
2add871
Compare
@@ -486,8 +486,9 @@ const createApp = async (app) => { | |||
res.set('Expires', '-1'); | |||
res.set('Pragma', 'no-cache'); | |||
res.send(withOptionValued); | |||
} else { | |||
res.status(503).send({ status: 'error', error: 'Interface is disabled by configuration' }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding an else prevent a stacktrace in log when favicon is requested.
ba9fab2
to
bb0bbc9
Compare
opencti-platform/opencti-graphql/tests/02-integration/04-manager/taskManager-test.ts
Outdated
Show resolved
Hide resolved
opencti-platform/opencti-graphql/tests/02-integration/04-manager/taskManager-test.ts
Outdated
Show resolved
Hide resolved
8b9a524
to
4ccaaca
Compare
@@ -194,7 +194,7 @@ export const getScenarioResult = async (id: string) => { | |||
human, | |||
}; | |||
} catch (err) { | |||
logApp.info('Scenario not found in OpenBAS', { err }); | |||
logApp.debug('Scenario not found in OpenBAS', { err }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the use of logApp.debug even necessary now?
Proposed changes
Other improvement:
"Error: Cannot set headers after they are sent to the client
)Related issues
Checklist
Further comments