Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add a test-result folder in backend to help debug stream count issues. #9480

Merged
merged 4 commits into from
Jan 3, 2025

Conversation

aHenryJard
Copy link
Member

@aHenryJard aHenryJard commented Dec 31, 2024

Proposed changes

It's hard to understand number different on counter without data reference on master. I propose to add a dump of event content in the JFrog archived artefact.

  • add an test utily to dump data to file in a dedicated folder "test-results" (similar to frontend folder name)
  • compress and send to JFrog

Related issues

No issue, it's out of band.
done in context of #9394

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

After a "json format" locally, it gives a diff like this:
image

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Dec 31, 2024
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.34%. Comparing base (1cafb54) to head (00c446d).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9480   +/-   ##
=======================================
  Coverage   65.34%   65.34%           
=======================================
  Files         624      624           
  Lines       59697    59697           
  Branches     6683     6690    +7     
=======================================
+ Hits        39010    39011    +1     
+ Misses      20687    20686    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aHenryJard aHenryJard marked this pull request as ready for review December 31, 2024 09:23
@aHenryJard aHenryJard force-pushed the oob/stream-debug-helper branch from 84408c2 to 00c446d Compare December 31, 2024 12:11
@marieflorescontact marieflorescontact self-requested a review January 2, 2025 08:56
@aHenryJard aHenryJard merged commit 8a66e8b into master Jan 3, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants