Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] base_edifact: Migration to 16.0 #813

Merged
merged 5 commits into from
Oct 18, 2023
Merged

[16.0][MIG] base_edifact: Migration to 16.0 #813

merged 5 commits into from
Oct 18, 2023

Conversation

QuocDuong1306
Copy link

@QuocDuong1306 QuocDuong1306 commented Sep 12, 2023 •
edited
Loading

@QuocDuong1306 QuocDuong1306 force-pushed the 16.0-mig-base_edifact branch 2 times, most recently from edd95f0 to 9216a16 Compare September 12, 2023 10:25
simahawk
simahawk requested changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to see some more test cov

base_edifact/__manifest__.py Outdated Show resolved Hide resolved
base_edifact/__manifest__.py Outdated Show resolved Hide resolved
base_edifact/tests/test_base_edifact.py Outdated Show resolved Hide resolved
base_edifact/tests/test_base_edifact.py Outdated Show resolved Hide resolved
@simahawk simahawk mentioned this pull request Oct 2, 2023
Merged
3 tasks
@QuocDuong1306 QuocDuong1306 force-pushed the 16.0-mig-base_edifact branch 2 times, most recently from 567ef85 to 4ea20e4 Compare October 3, 2023 08:22
@QuocDuong1306
Copy link
Author

Thank @simahawk , I updated

@simahawk simahawk mentioned this pull request Oct 5, 2023
Closed
simahawk
simahawk approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG overall

base_edifact/models/edifact.py Show resolved Hide resolved
@simahawk simahawk mentioned this pull request Oct 11, 2023
Merged
@simahawk
Copy link
Contributor

/ocabot migration base_edifact

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Oct 17, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 2, 2023
Open
17 tasks
@simahawk
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-813-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ea1bcc7 into OCA:16.0 Oct 18, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 661008c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@QuocDuong1306 @simahawk @OCA-git-bot @rmorant