[16.0][ADD] edi_edifact_oca #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuocDuong1306
force-pushed
the
16.0-add-edi_edifact_oca
branch
from
a249fbc
to
71b2f70
Compare
simahawk
requested changes
Oct 2, 2023
There was a problem hiding this comment.
As mentioned on OCA/edi#813 the dependencies have to be fixed.
THIS module here is the on that should plug the party data module.
QuocDuong1306
force-pushed
the
16.0-add-edi_edifact_oca
branch
2 times, most recently
from
07598ab
to
f862559
Compare
QuocDuong1306
force-pushed
the
16.0-add-edi_edifact_oca
branch
3 times, most recently
from
7359928
to
c90cbf3
Compare
simahawk
requested changes
Oct 10, 2023
| ) | ||
|
|
||
| def test_lookup_default(self): | ||
| provider = get_party_data_component(self.exc_record_no_edifact, self.partner) |
There was a problem hiding this comment.
You are not testing at all your the code of this module... you are testing the base component... seems useless.
QuocDuong1306
force-pushed
the
16.0-add-edi_edifact_oca
branch
2 times, most recently
from
a009ba5
to
3b9f49f
Compare
QuocDuong1306
force-pushed
the
16.0-add-edi_edifact_oca
branch
from
3b9f49f
to
5440315
Compare
simahawk
approved these changes
Oct 24, 2023
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 6bc6355. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module provides a basic configuration for EDIFACT with the EDI framework.
Depends on: