Skip to content

Commit

Permalink
[IMP] account_invoice_facturx: add RateApplicablePercent in XML when …
Browse files Browse the repository at this point in the history
…there is not tax (avoid an error in Chorus Pro)

Add warning in README about alternative module in official addons.
  • Loading branch information
alexis-via committed Oct 1, 2024
1 parent 9a2ebf0 commit 7fd973a
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 7 deletions.
8 changes: 7 additions & 1 deletion account_invoice_facturx/README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,20 @@ ZUGFeRD/Factur-X PDF invoice:
Installation
============

**WARNING**: there is an alternative implementation of Factur-X in the
module **account_edi_ubl_cii** of the official addons. If both modules
are installed, the XML embedded in the PDF is the XML generated by the
module **account_edi_ubl_cii**. To avoid that, you need to uninstall the
module **account_edi_ubl_cii**.

This module requires a recent version of the Python library
`factur-x <https://github.com/akretion/factur-x>`__ developped by
Akretion. Note that the factur-x library depends on PyPDF2 for the
low-level PDF manipulation. To install it, run:

::

sudo pip3 install --upgrade factur-x
pip3 install --upgrade factur-x

Configuration
=============
Expand Down
1 change: 1 addition & 0 deletions account_invoice_facturx/models/account_move.py
Original file line number Diff line number Diff line change
Expand Up @@ -393,6 +393,7 @@ def _cii_check_tax_required_info(self, tax_dict):
"unece_type_code": "VAT",
"unece_categ_code": "E",
"amount": 0,
"amount_type": "percent",
"display_name": "Empty virtual tax",
}
)
Expand Down
4 changes: 3 additions & 1 deletion account_invoice_facturx/readme/INSTALL.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
**WARNING**: there is an alternative implementation of Factur-X in the module **account_edi_ubl_cii** of the official addons. If both modules are installed, the XML embedded in the PDF is the XML generated by the module **account_edi_ubl_cii**. To avoid that, you need to uninstall the module **account_edi_ubl_cii**.

This module requires a recent version of the Python library
[factur-x](https://github.com/akretion/factur-x) developped by Akretion.
Note that the factur-x library depends on PyPDF2 for the low-level PDF
manipulation. To install it, run:

```
sudo pip3 install --upgrade factur-x
pip3 install --upgrade factur-x
```
18 changes: 13 additions & 5 deletions account_invoice_facturx/static/description/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,11 @@

/*
:Author: David Goodger ([email protected])
:Id: $Id: html4css1.css 8954 2022-01-20 10:10:25Z milde $
:Id: $Id: html4css1.css 9511 2024-01-13 09:50:07Z milde $
:Copyright: This stylesheet has been placed in the public domain.

Default cascading style sheet for the HTML output of Docutils.
Despite the name, some widely supported CSS2 features are used.

See https://docutils.sourceforge.io/docs/howto/html-stylesheets.html for how to
customize this style sheet.
Expand Down Expand Up @@ -274,7 +275,7 @@
margin-left: 2em ;
margin-right: 2em }

pre.code .ln { color: grey; } /* line numbers */
pre.code .ln { color: gray; } /* line numbers */
pre.code, code { background-color: #eeeeee }
pre.code .comment, code .comment { color: #5C6576 }
pre.code .keyword, code .keyword { color: #3B0D06; font-weight: bold }
Expand All @@ -300,7 +301,7 @@
span.pre {
white-space: pre }

span.problematic {
span.problematic, pre.problematic {
color: red }

span.section-subtitle {
Expand Down Expand Up @@ -407,12 +408,17 @@ <h1 class="title">Account Invoice Factur-X</h1>
</div>
<div class="section" id="installation">
<h1><a class="toc-backref" href="#toc-entry-1">Installation</a></h1>
<p><strong>WARNING</strong>: there is an alternative implementation of Factur-X in the
module <strong>account_edi_ubl_cii</strong> of the official addons. If both modules
are installed, the XML embedded in the PDF is the XML generated by the
module <strong>account_edi_ubl_cii</strong>. To avoid that, you need to uninstall the
module <strong>account_edi_ubl_cii</strong>.</p>
<p>This module requires a recent version of the Python library
<a class="reference external" href="https://github.com/akretion/factur-x">factur-x</a> developped by
Akretion. Note that the factur-x library depends on PyPDF2 for the
low-level PDF manipulation. To install it, run:</p>
<pre class="literal-block">
sudo pip3 install --upgrade factur-x
pip3 install --upgrade factur-x
</pre>
</div>
<div class="section" id="configuration">
Expand Down Expand Up @@ -453,7 +459,9 @@ <h2><a class="toc-backref" href="#toc-entry-6">Contributors</a></h2>
<div class="section" id="maintainers">
<h2><a class="toc-backref" href="#toc-entry-7">Maintainers</a></h2>
<p>This module is maintained by the OCA.</p>
<a class="reference external image-reference" href="https://odoo-community.org"><img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" /></a>
<a class="reference external image-reference" href="https://odoo-community.org">
<img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" />
</a>
<p>OCA, or the Odoo Community Association, is a nonprofit organization whose
mission is to support the collaborative development of Odoo features and
promote its widespread use.</p>
Expand Down

0 comments on commit 7fd973a

Please sign in to comment.