Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix)cargo doc workflow #741

Merged
merged 2 commits into from
May 10, 2023
Merged

(fix)cargo doc workflow #741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38516d2
(fix)cargo doc workflow
Hounsette May 9, 2023
7f2cb5a
Update rust-toolchain
Hounsette May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions .github/workflows/doc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,20 +3,13 @@ name: Rust AutoDoc
on:
push:
branches: master

env:
nightly: nightly-2022-09-20
target: wasm32-unknown-unknown

jobs:
autodoc:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions-rust-lang/setup-rust-toolchain@v1
with:
toolchain: ${{ env.nightly }}
target: ${{ env.target }}
- run: rustup show
Comment on lines -16 to +11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By this are we relying on the version of the rust that is preinstalled on the ubuntu-latest machine?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more reading here.
It will be overridden by the version declared in the rust-toolchain file.

We can replace all the actions-rust-lang/setup-rust-toolchain@v1 in the workflow files by rustup show

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Hounsette. The link you have put here seems not relevant to our discussion or I couldn't find out how. Also I have noticed after the merge of this PR some builds have failed. I still don't get how rustup show can replace setting up the toolchain if it's not already setup.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was the wrong link, here is the explanation.


- name: Install protobuf-compiler
run: |
sudo apt-get install protobuf-compiler
Expand Down
5 changes: 5 additions & 0 deletions rust-toolchain
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
[toolchain]
channel = "nightly-2023-03-08"
components = [ "rustfmt", "clippy" ]
targets = [ "wasm32-unknown-unknown" ]
profile = "minimal"