(fix)cargo doc workflow #741
Conversation
Codecov Report
@@ Coverage Diff @@
## master #741 +/- ##
=======================================
Coverage 59.03% 59.03%
=======================================
Files 38 38
Lines 4670 4670
=======================================
Hits 2757 2757
Misses 1913 1913 |
| - uses: actions-rust-lang/setup-rust-toolchain@v1 | ||
| with: | ||
| toolchain: ${{ env.nightly }} | ||
| target: ${{ env.target }} | ||
| - run: rustup show |
There was a problem hiding this comment.
By this are we relying on the version of the rust that is preinstalled on the ubuntu-latest machine?
There was a problem hiding this comment.
more reading here.
It will be overridden by the version declared in the rust-toolchain file.
We can replace all the actions-rust-lang/setup-rust-toolchain@v1 in the workflow files by rustup show
There was a problem hiding this comment.
Hey @Hounsette. The link you have put here seems not relevant to our discussion or I couldn't find out how. Also I have noticed after the merge of this PR some builds have failed. I still don't get how rustup show can replace setting up the toolchain if it's not already setup.
There was a problem hiding this comment.
It was the wrong link, here is the explanation.
No description provided.