Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos-rebuild: fix for NIX_SSHOPTS #342596

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

nixos-rebuild: fix for NIX_SSHOPTS #342596

wants to merge 5 commits into from
+162 −129

Commits on Oct 6, 2024

  1. nixos-rebuild: move $SSHOPTS declaration after fun definitions 

    When I tried to update a node with a specific ssh key using the ssh `-i`
flag. It threw an error:

```
Permission denied (publickey)
```

But the path and key were correct, I could connect via ssh directly. The
problem is that in NixOS#283634 we have started running the remote command to
get the hostname, but $SSHOPTS is declared below that line, causing them
to be ignored.
    @name-snrl
    name-snrl committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    3bf0995 View commit details
    Browse the repository at this point in the history

  2. nixos-rebuild: move the option check code to one place

    @name-snrl
    name-snrl committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    7300ddc View commit details
    Browse the repository at this point in the history

  3. nixos-rebuild: move the preparations to a separate section

    @name-snrl
    name-snrl committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    cb22d6f View commit details
    Browse the repository at this point in the history

  4. nixos-rebuild: make sure nix will not build for edit 

    At the moment `edit` really doesn't rebuild nix, but that's because of
the order in which the commands are executed. This doesn't seem like a
reliable solution, so I defined it in a more explicit way
    @name-snrl
    name-snrl committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    d621811 View commit details
    Browse the repository at this point in the history

  5. nixos-rebuild: move nix build functions above

    @name-snrl
    name-snrl committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    eaa7c94 View commit details
    Browse the repository at this point in the history