nixos-rebuild: fix for NIX_SSHOPTS #342596
Open
+162
−129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I tried to update a node with a specific ssh key using the ssh `-i` flag. It threw an error: ``` Permission denied (publickey) ``` But the path and key were correct, I could connect via ssh directly. The problem is that in NixOS#283634 we have started running the remote command to get the hostname, but $SSHOPTS is declared below that line, causing them to be ignored.
At the moment `edit` really doesn't rebuild nix, but that's because of the order in which the commands are executed. This doesn't seem like a reliable solution, so I defined it in a more explicit way
name-snrl
force-pushed
the
nixos-rebuild
branch
from
ccdb615
to
eaa7c94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Reopening #326636. Apologies to anyone I mistakenly mentioned in that thread.
Note that if the target system does not include this patch, you should use the
--fastoption, otherwisenixos-rebuildfrom the target system will be used.@roberth I added a test case to
nixos-rebuild-target-host, I think this is an appropriate place. I've also added some commits that group some pieces of code together. I'm not sure if this is really necessary, but I wanted to bring more clarity to the mess.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.