libtins: Force compilation using C++14. #290931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmnipotentEntity
approved these changes
Mar 4, 2024
wegank
added
the
12.approvals: 1
|
Thanks! |
Closed
|
See upstream report at: mfontanini/libtins#529 @OmnipotentEntity next time, remember to file an issue upstream, and ideally link to it in a comment near the patch. |
|
Not my patch or PR, you want to be talking to @simonhollingshead Though I'll keep this in mind in the future when reviewing PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
#282245 breaks C++11 users. Libtins is not only a C++11 user, but it also has chunks of code dedicated to working out which C++11 features are enabled to choose whether to include the C++ optimisations or not.
In this change, I've decided to just force C++14 mode and to remove the check on whether the features are enabled or not. Otherwise I would have to port the enablement checks and probably perform a lot of renaming throughout the codebase for accuracy.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.