Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libtins: 4.4 -> 4.5 #255639

Closed
wants to merge 1 commit into from
Closed

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/mfontanini/libtins/releases.

meta.description for libtins is: High-level, multiplatform C++ network packet sniffing and crafting library

meta.homepage for libtins is: https://libtins.github.io/

meta.changelog for libtins is: https://raw.githubusercontent.com/mfontanini/libtins/v4.5/CHANGES.md

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 4.5 with grep in /nix/store/qm14r18n52gwkw6lf8adn3bh9iyrkvb3-libtins-4.5
  • found 4.5 in filename of file in /nix/store/qm14r18n52gwkw6lf8adn3bh9iyrkvb3-libtins-4.5

Rebuild report (if merged into master) (click to expand)
4 total rebuild path(s)

4 package rebuild(s)

First fifty rebuilds by attrpath
compactor
libtins
mathematica
mathematica-cuda
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/qm14r18n52gwkw6lf8adn3bh9iyrkvb3-libtins-4.5 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A libtins https://github.com/r-ryantm/nixpkgs/archive/18a71209e96003ecb7f0a23a6ab7a74968ed5aa9.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/18a71209e96003ecb7f0a23a6ab7a74968ed5aa9#libtins

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/qm14r18n52gwkw6lf8adn3bh9iyrkvb3-libtins-4.5
ls -la /nix/store/qm14r18n52gwkw6lf8adn3bh9iyrkvb3-libtins-4.5/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

3 packages failed to build:
  • compactor
  • mathematica
  • mathematica-cuda
1 package built:
  • libtins

Maintainer pings

cc @fdns for testing.

@doronbehar
Copy link
Contributor

The mathematica failures are not due to update, but rather due to the lack of installer script and the fact they are unfree. The only real failure is compactor. Noting for future people arriving here: Apparently #290931 is needed even for version 4.5. I also reported it upstream at mfontanini/libtins#529 .

@doronbehar
Copy link
Contributor

In #296217 I tested both compactor and mathematica for basic functionality, and both seem to accept libtins4.5 (with the gtest patch) fine. Merging it will close this PR.

@r-ryantm r-ryantm deleted the auto-update/libtins branch March 17, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants