Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug-fix] Remove assert-invalidating parentheses #837

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NellyWhads
Copy link

Fix always-true assert statement

@NellyWhads
Copy link
Author

Have the two test outputs here, one on master and one on the incoming branch.

torch2trt_test_master.md

NUM_TESTS: 391
NUM_SUCCESSFUL_CONVERSION: 390
NUM_FAILED_CONVERSION: 1
NUM_ABOVE_TOLERANCE: 1
NUM_pSNR_TOLERANCE: 6

torch2trt_test.md

NUM_TESTS: 391
NUM_SUCCESSFUL_CONVERSION: 390
NUM_FAILED_CONVERSION: 1
NUM_ABOVE_TOLERANCE: 2
NUM_pSNR_TOLERANCE: 5

Is there anything I can do to overcome the failed case?

@jaybdub
Copy link
Contributor

jaybdub commented Apr 28, 2023

Hi @NellyWhadsDev , Thanks for the PR!

Do you mind sharing the setup where the original throws error / the fix does not?

Wondering if this is unique to a specific version of Python, or if the original code was just an oversight.

Thanks!
John

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants