629 upgrade bootstrap 5 #630
Conversation
This work will need the 629-upgrade-bootstrap-5 MATScommon branch checked out as well. In MATS - I've upgraded bootstrap to v5 everywhere I could find it and removed the duplicate bootstrap 3 dependency from the atmosphere package list. I'm not sure if this was wise. Either way, it resulted in a very broken MATS UI.
|
As a heads up, you're also going to want to create that branch in METexpress, if you want to avoid having trouble with the build. |
|
Thanks Molly! You were a few minutes ahead of me. I've pushed my MATScommon changes here: dtcenter/MATScommon#4 This is all just a shot in the dark at seeing if I could get something working. (Spoiler - the UI's pretty broken with this change) I'd definitely appreciate your thoughts on what I pushed. |
|
I'll take a look after this meeting! Thanks, Ian! |
|
These changes look like a good start! If Hera isn't back up after our next meeting (it probably won't be), I'll checkout some local branches and see if I see anything causing the GUI not to work properly. It looks like the individual apps don't have any access to bootstrap or jQuery anymore, and they might not need it, but have you checked that yet? |
|
Would you mind creating this branch in METexpress too, so that I know I'm testing the correct code? (Also, those apps will have the same meteor packages that need updating). |
|
Can do. Do you just need the branch name to exist? I should mention - I only upgraded MATScommon and the aircraft app in MATS to keep things as simple as possible for now. I've created the branch here: https://github.com/dtcenter/METexpress/tree/629-upgrade-bootstrap-5 |
|
Just existing is fine! I just end up getting really confused if half of my project is on development and half is on a feature branch. Plus it’s really easy to accidentally push unfinished code to origin/development that way, I’ve done that more times than I want to admit :)
… On Sep 1, 2021, at 4:54 PM, Ian McGinnis ***@***.***> wrote:
Can do. Do you just need the branch name to exist? I should mention - I only upgraded MATScommon and the aircraft app in MATS to keep things as simple as possible for now.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#630 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHBWGZOK6OHLNBBA7Y7L44TT72VMDANCNFSM5DG3YUEA>.
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
# Conflicts: # MATScommon # apps/aircraft/.meteor/packages # apps/aircraft/.meteor/release # apps/aircraft/.meteor/versions
|
This PR is stale because it has been open 90 days with no activity. |
Initial attempt at migrating from bootstrap 4 to 5. This is just a draft and we can delete it if there's a better direction to go in.
This branch will need the 629-upgrade-bootstrap-5 MATScommon branch checked out as well. In MATS - I've upgraded bootstrap to v5 everywhere I could find it and removed the duplicate bootstrap 3 dependency from the atmosphere package list. I'm not sure if this was wise. Either way, it resulted in a very broken MATS UI.