Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Bootstrap 5 #629

Open
ian-noaa opened this issue Aug 30, 2021 · 10 comments
Open

Upgrade to Bootstrap 5 #629

ian-noaa opened this issue Aug 30, 2021 · 10 comments
Assignees
Labels
Don't use: Medium Low urgency with moderate value epic A piece of functionality directly related to requirements similar to an epic user story Stale

Comments

@ian-noaa
Copy link
Collaborator

ian-noaa commented Aug 30, 2021

Bootstrap 5 was released earlier this year and drops the requirement for JQuery. Bootstrap 4's JQuery dependency is one of the reasons we couldn't switch to using GSL's production rancher cluster. (For more - see #624. )

Bootstrap has published a v4 -> v5 migration guide here: https://getbootstrap.com/docs/5.1/migration/

@ian-noaa ian-noaa added Don't use: High Greater urgency that needs to go in the next major release Type: Enhancment labels Aug 30, 2021
@mollybsmith-noaa
Copy link
Collaborator

You assigned this to me, so I take it you want me to do this migration?

@ian-noaa
Copy link
Collaborator Author

If that's okay with you, I think you're better positioned to do this than I am.

@mollybsmith-noaa
Copy link
Collaborator

If I can shoehorn it into my schedule, sure.

@ian-noaa
Copy link
Collaborator Author

ian-noaa commented Aug 30, 2021

Okay. Thanks, Molly. When you get to it, let me know if I can help or if it isn't going to work in your schedule.

@mollybsmith-noaa
Copy link
Collaborator

Sounds good and thanks, I'll keep you posted!

@bonnystrong
Copy link

bonnystrong commented Aug 30, 2021 via email

@ian-noaa
Copy link
Collaborator Author

👍 I definitely plan on watching the PR/commits associated with this!

@ian-noaa ian-noaa linked a pull request Sep 1, 2021 that will close this issue
@ian-noaa
Copy link
Collaborator Author

ian-noaa commented Sep 1, 2021

@mollybsmith-noaa - I've pushed a draft PR capturing what I've tried as far as updating bootstrap in case it's a helpful starting point. (#630) We definitely don't need to keep the PR if it's not helpful. It's resulted in a very broken MATS UI.

@ian-noaa ian-noaa self-assigned this Sep 22, 2021
@ian-noaa ian-noaa added Don't use: Medium Low urgency with moderate value and removed Don't use: High Greater urgency that needs to go in the next major release labels Apr 27, 2022
@ian-noaa ian-noaa added the epic A piece of functionality directly related to requirements similar to an epic user story label May 4, 2022
@mollybsmith-noaa
Copy link
Collaborator

Re-assigning this to Randy because he's actively working on it.

@github-actions
Copy link

This issue is stale because it has been open 90 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Don't use: Medium Low urgency with moderate value epic A piece of functionality directly related to requirements similar to an epic user story Stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants