Changes to conftest.py for translate tests #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmalatino
requested review from
xyuan,
FlorianDeconinck,
oelbert,
bensonr and
mlee03
fmalatino
changed the title
mysign variable as external
FlorianDeconinck
previously approved these changes
Jun 17, 2024
7 tasks
oelbert
previously approved these changes
Jun 18, 2024
fmalatino
changed the title
mysign variable as external
bensonr
previously approved these changes
Jul 1, 2024
mlee03
reviewed
Jul 1, 2024
.github/workflows/translate.yml
Outdated
| @@ -0,0 +1,80 @@ | |||
| name: "Translate test (subset)" | |||
bensonr
approved these changes
Jul 8, 2024
mlee03
reviewed
Jul 8, 2024
| test_requirements = ["pytest", "pytest-subtests", "serialbox"] | ||
| ndsl_requirements = ["ndsl @ git+https://github.com/NOAA-GFDL/NDSL.git@2024.04.00"] | ||
| test_requirements = ["pytest", "pytest-subtests", "serialbox", "coverage"] | ||
| ndsl_requirements = ["ndsl @ git+https://github.com/NOAA-GFDL/NDSL.git@develop"] |
There was a problem hiding this comment.
quick question, why the develop branch and not a specific tag?
There was a problem hiding this comment.
We are using the develop branch as the release is not ready yet, and that the develop branch contains the configurations needed for testing. Once the orchestration issue is resolved the new release will be made and there will be a subsequent PR to update this.
mlee03
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The conftest.py file for the translate tests has been changed to match centralized test structure in NDSL.
How Has This Been Tested?
Tested with the current translate test structure triggering the appropriate downstream repositories.
Checklist: