Cleanup pass in setup.py #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fully move from AI2 to NOAA-GDFL - Restrict python version to 3.11 - Consistent license information - Pin NDSL at latest release (2024.09.00)
romanc
force-pushed
the
romanc/cleanup-setup-py
branch
from
a3e3ce0
to
021e524
Compare
|
@fmalatino @oelbert would you mind to review this? And can someone else add Rusty to the list of reviewers? I can't seem to find him. I'd add you guys as reviewers if I could. Looks like I don't have the rights to do this. /cc @FlorianDeconinck as discussed. |
fmalatino
previously approved these changes
Nov 13, 2024
oelbert
previously approved these changes
Nov 13, 2024
bensonr
reviewed
Nov 13, 2024
romanc
commented
Nov 13, 2024
This was added a while back (at AI2) when - for a brief amount of time - the idea as to ship some translate test data with the package. This idea was rejected and now the configuration option isn't needed anymore.
|
Thanks for all the discussions. This is ready for a second round of reviews. |
romanc
requested review from
bensonr,
fmalatino,
oelbert and
FlorianDeconinck
fmalatino
approved these changes
Nov 14, 2024
|
Someone with write access to the repo will need to merge this PR. I don't have the rights to do this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does a pass on the
setup.pyfile and changes the followingThis is a follow-up from a couple of PRs and mentions including
coveragetool to unit tests in workflow #21 (comment) and Addition ofcoveragetool to unit tests in workflow #21 (review) which advocated for a holistic pass on the fileHow Has This Been Tested?
Tested
python_requireslocally (with different python version and multiple virtual environments)Checklist: