Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the IMS pre-processing time and IMS snow data format #2779

Closed
wants to merge 5 commits into from
Closed

Update the IMS pre-processing time and IMS snow data format #2779

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ba3338f
Change to process IMS snow from the 18z to the 00z cycle.
jiaruidong2017 Jul 17, 2024
15fb45e
Include the changes from GDASApp.
jiaruidong2017 Jul 18, 2024
7773f81
Address reviewer's comments.
jiaruidong2017 Jul 19, 2024
152e3a8
Update the changes from GDASApp.
jiaruidong2017 Jul 19, 2024
d10c3f5
Merge branch 'develop' into feature/ims_ascii
jiaruidong2017 Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion scripts/exglobal_prep_snow_obs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,6 @@
# Instantiate the snow prepare task
SnowAnl = SnowAnalysis(config)
SnowAnl.prepare_GTS()
if f"{ SnowAnl.task_config.cyc }" == '18':
SnowAnl.task_config.cyc = f'{SnowAnl.task_config.cyc:02d}'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep the leading '0' for the 00z cycle to be '00', so that the following if f"{ SnowAnl.task_config.cyc }" == '00': is true for the 00z

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't it just be if SnowAnl.task_config.cyc == 0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the according changes. Thanks.

if f"{ SnowAnl.task_config.cyc }" == '00':
SnowAnl.prepare_IMS()
2 changes: 1 addition & 1 deletion sorc/gdas.cd
Open in desktop
Submodule gdas.cd updated 50 files
+1 −0 .gitignore
+0 −8 .gitmodules
+15 −3 bundle/CMakeLists.txt
+18 −0 bundle/fv3-interface.cmake
+1 −0 modulefiles/GDAS/gaea.intel.lua
+4 −3 modulefiles/GDAS/hera.intel.lua
+4 −3 modulefiles/GDAS/hercules.intel.lua
+1 −0 modulefiles/GDAS/noaacloud.intel.lua
+4 −3 modulefiles/GDAS/orion.intel.lua
+6 −2 modulefiles/GDAS/wcoss2.intel.lua
+37 −13 parm/aero/berror/aero_diagb.yaml.j2
+15 −13 parm/aero/berror/aero_diffusionparm.yaml.j2
+50 −0 parm/aero/berror/aero_interp.yaml.j2
+137 −0 parm/snow/jcb-base.yaml.j2
+7 −0 parm/snow/jcb-fv3jedi_land_ensrecenter.yaml.j2
+10 −0 parm/snow/letkfoi/ens_apply_incr_nml.j2
+1 −1 parm/snow/obs/lists/gdas_snow.yaml.j2
+1 −1 parm/snow/prep/fims.nml.j2
+1 −1 parm/snow/prep/prep_ims.yaml.j2
+2 −2 parm/soca/letkf/letkf.yaml.j2
+0 −38 parm/soca/letkf/letkf_stage.yaml.j2
+40 −0 parm/soca/soca_ens_bkg_stage.yaml.j2
+3 −0 parm/soca/soca_fix_stage.yaml.j2
+1 −1 scripts/exgdas_global_marine_analysis_prep.py
+0 −1 sorc/fms
+1 −1 sorc/fv3
+1 −1 sorc/fv3-jedi
+1 −1 sorc/fv3-jedi-lm
+1 −1 sorc/ioda
+1 −1 sorc/iodaconv
+1 −1 sorc/land-imsproc
+0 −1 sorc/mom6
+1 −1 sorc/oops
+1 −1 sorc/saber
+1 −1 sorc/soca
+1 −1 sorc/ufo
+1 −1 sorc/vader
+8 −7 test/CMakeLists.txt
+1 −1 test/aero/global-workflow/jjob_var_init.sh
+10 −14 test/atm/global-workflow/3dvar.ref
+2 −2 test/atm/global-workflow/jjob_ens_init.sh
+4 −4 test/atm/global-workflow/jjob_var_init.sh
+1 −1 test/snow/apply_jedi_incr.sh
+1 −1 test/snow/create_bkg_ens.sh
+1 −1 test/snow/letkfoi_snowda.sh
+1 −1 test/snow/test_imsproc.sh
+11 −11 test/soca/gw/prep.sh
+1 −1 ush/soca/marine_recenter.py
+4 −4 ush/soca/run_jjobs.py
+59 −4 utils/chem/chem_diagb.h
Loading