-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the IMS pre-processing time and IMS snow data format #2779
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conditionally approve pending CI
This PR updates the IMS snow data pre-processing time from being the 18z to the 00z cycle, and also changes to assimilate the IMS snow data in ascii format from the operational dump. This PR contributes to NOAA-EMC/global-workflow#2779
scripts/exglobal_prep_snow_obs.py
Outdated
@@ -21,5 +21,6 @@ | |||
# Instantiate the snow prepare task | |||
SnowAnl = SnowAnalysis(config) | |||
SnowAnl.prepare_GTS() | |||
if f"{ SnowAnl.task_config.cyc }" == '18': | |||
SnowAnl.task_config.cyc = f'{SnowAnl.task_config.cyc:02d}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To keep the leading '0' for the 00z cycle to be '00', so that the following if f"{ SnowAnl.task_config.cyc }" == '00':
is true for the 00z
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't it just be if SnowAnl.task_config.cyc == 0
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the according changes. Thanks.
Looks good, the g-w team will need to work with @jiaruidong2017 to update the test data before kicking off CI |
@KateFriedman-NOAA @WalterKolczynski-NOAA |
@KateFriedman-NOAA @WalterKolczynski-NOAA Would you please copy the test data: |
@jiaruidong2017 I have copied the file into the GDA on Hera:
I have also synced this to the GDA on both WCOSS2s. @WalterKolczynski-NOAA please sync this file to the GDA on Orion, thanks! |
We also need to copy to
The 20211221 00Z gfsprepsnowobs from g-w C96_atmaerosnowDA CI fails because |
Thanks @RussTreadon-NOAA. Yes, @KateFriedman-NOAA would you please make the copy. Thanks. |
I think this PR is needed to be merged to fix failures seen in CI testing on #2749 |
Could you resolve the conflict @jiaruidong2017 ? |
@guillaumevernieres I learn to try it by merging branch |
@jiaruidong2017 @RussTreadon-NOAA I have also copied the gfs file into the GDA on Hera:
...and synced it to both WCOSS2s. @WalterKolczynski-NOAA please also sync this file to Orion, thanks! |
Thank you @KateFriedman-NOAA for updating the GDA. I reran the failed 20211221 00Z gfsprepsnowobs from C96_atmaerosnowDA CI. The job successfully ran to completion. |
Synchronized to MSU. |
|
Failed on cloning and building global-workflowi PR: 2779 |
Build FAILED on Hercules with error logs:
Follow link here to view the contents of the above file(s): (link) |
@guillaumevernieres any idea what happened here? Did something change in SOCA with MOM6? |
@jiaruidong2017 , did you intend to update the |
@guillaumevernieres is working on this to merge my changes to his branch. |
Thank you @jiaruidong2017 for the update. Thank you @guillaumevernieres for merging PR #2779 into #2749. |
Manually killed CI tests on Hera and Hercules which had stalled. Will restart testing on #2749 when merged and approved. |
This PR will be merged into the PR #2749. |
Description
Since the IMS snow products was ingested at about 23:00 UTC, and the IMS snow cover data is in the ascii format. Therefore, we propose to assimilate the IMS snow cover data in the ascii format at 00z cycle.
This PR updates the IMS snow data pre-processing time from being the 18z to the 00z cycle, and also changes to assimilate the IMS snow data in ascii format from the operational dump.
An IMS snow data in ascii format will be staged to global dump directory for the CI test
C96_atmaerosnowDA.yaml
at:/scratch1/NCEPDEV/global/Jiarui.Dong/JEDI/GlobalWorkflow/para_gfs/glopara_dump/gdas.20211221/00/atmos/gdas.t00z.imssnow96.asc
This PR depends on NOAA-EMC/GDASApp#1228
Type of change
Change characteristics
How has this been tested?
Cycled test on Hera
Checklist