Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring of the marine B-matrix job #2749
Refactoring of the marine B-matrix job #2749
Changes from 6 commits
17494de
58115a6
5438a47
ee36b5e
8ae7f79
ba665f4
6900fc4
2d21d3d
8e137d0
216df7f
612b456
c034653
2311b4f
faa84bf
4913ff9
c93a43b
0e2e05e
6ab9a5d
96db47e
f6aaf60
8a7b148
7cf347d
c8cbba0
75cfc93
112085f
4e69124
6e0e2dc
4da5791
a0a34d9
ee30556
a209510
65eb775
c05582b
bbc1fa0
017d191
4ba7dee
3e85a94
5a7dd31
6d3704c
507b62d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why
_run
?EE2 will make us change this to match the j-job name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, will push the changes after I'm done testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This need not be this way.
See above comment.
If there is a dependence on the number of levels, we can make a case statement here and cover all cases.