Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/noaa csp aws rtd update #1960

Closed
wants to merge 9 commits into from
Closed

Feature/noaa csp aws rtd update #1960

wants to merge 9 commits into from

Conversation

HenryRWinterbottom
Copy link
Contributor

Description

This PR updates the docs/source/noaa-csp.rst file such that it is up-to-date with the path to the global-workflow stack for NOAA CSP AWS.

Resolves #1959
Refs #4321
Refs NOAA-EMC/repo#5678
-->

Type of change

  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

N/A

Example:
N/A

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

@HenryRWinterbottom HenryRWinterbottom self-assigned this Oct 23, 2023
@HenryRWinterbottom HenryRWinterbottom added the documentation Improvements or additions to documentation label Oct 23, 2023
@github-actions
Copy link

Link to ReadTheDocs sample build for this PR can be found at:
https://global-workflow--1960.org.readthedocs.build/en/1960

if [[ ! -d "${!prod_dir}" ]]; then mkdir -m 775 -p "${!prod_dir}"; fi
done

if [ "${RUN}" = gfs ];then

Check notice

Code scanning / shellcheck

Prefer [[ ]] over [ ] for tests in Bash/Ksh. Note

Prefer [[ ]] over [ ] for tests in Bash/Ksh.
if [ "${RUN}" = gfs ];then
export FHOUT_PGB=${FHOUT_GFS:-3} #Output frequency of gfs pgb file at 1.0 and 0.5 deg.
fi
if [ "${RUN}" = gdas ]; then

Check notice

Code scanning / shellcheck

Prefer [[ ]] over [ ] for tests in Bash/Ksh. Note

Prefer [[ ]] over [ ] for tests in Bash/Ksh.
export FHOUT_PGB=${FHOUT:-1} #Output frequency of gfs pgb file at 1.0 and 0.5 deg.
fi

if [ "${GRIBVERSION}" = grib2 ]; then

Check notice

Code scanning / shellcheck

Prefer [[ ]] over [ ] for tests in Bash/Ksh. Note

Prefer [[ ]] over [ ] for tests in Bash/Ksh.
##############################################
# Final processing
##############################################
if [ -e "${pgmout}" ]; then

Check notice

Code scanning / shellcheck

Prefer [[ ]] over [ ] for tests in Bash/Ksh. Note

Prefer [[ ]] over [ ] for tests in Bash/Ksh.
###############################################################

# Source FV3GFS workflow modules
. ${HOMEgfs}/ush/load_fv3gfs_modules.sh

Check notice

Code scanning / shellcheck

Double quote to prevent globbing and word splitting. Note

Double quote to prevent globbing and word splitting.
# Source FV3GFS workflow modules
. ${HOMEgfs}/ush/load_fv3gfs_modules.sh
status=$?
[[ ${status} -ne 0 ]] && exit ${status}

Check notice

Code scanning / shellcheck

Prefer double quoting even when variables don't contain special characters. Note

Prefer double quoting even when variables don't contain special characters.
export job="atmanlpost"
export jobid="${job}.$$"

${HOMEgfs}/jobs/JGLOBAL_ATMOSANL_POST

Check notice

Code scanning / shellcheck

Double quote to prevent globbing and word splitting. Note

Double quote to prevent globbing and word splitting.

${HOMEgfs}/jobs/JGLOBAL_ATMOSANL_POST
status=$?
[[ ${status} -ne 0 ]] && exit ${status}

Check notice

Code scanning / shellcheck

Prefer double quoting even when variables don't contain special characters. Note

Prefer double quoting even when variables don't contain special characters.
@WalterKolczynski-NOAA
Copy link
Contributor

This looks like it has the postanl work in it. Please clean the PR to only have the documentation update.

@HenryRWinterbottom HenryRWinterbottom closed this by deleting the head repository Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NOAA CSP AWS readthedocs update.
3 participants