Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UFS-dev PR#85 #104

Merged
merged 8 commits into from
Oct 3, 2023
Merged

UFS-dev PR#85 #104

merged 8 commits into from
Oct 3, 2023

Conversation

grantfirl
Copy link
Collaborator

Identical to ufs-community#1797

Also contains changes from ufs-community#1812

DeniseWorthen and others added 4 commits July 7, 2023 12:59
@DeniseWorthen
Send Evap rate from ATM to OCN (ufs-community#1812)
50db30e 
* send evap from atm

* instead of converting from lat->evap in prep_ocn, send evap from
atm directly. Sign change still needed.

* turn off c48-5deg warm start test

* disable hrrr tests on wcoss2
@SamuelTrahanNOAA
Bug fixes for RRFS 32-bit physics support, and minor feature additions (
f1f0180 
ufs-community#1797)

* refactor FV3GFS restart, add clm lake and rrfs-sd to quilt restart

* rrfs sd restart in quilt (still under testing)

* explicitly write axis values (from DusanJovic-NOAA), and clean up code

* rename FV3GFS to fv3atm in code, except output metadata

* refactor a bit more, putting history into fv3atm_history_io.F90 and restart into fv3atm_restart_io.F90

* add the two qr hurr_control tests

* bug fix to "alt check" code: add -S -q to avoid infinite output

* 32-bit quilt restart tests
@grantfirl
Merge commit 'f1f0180046ef72fcff6c4ed6c184a3396532af28' into ufs-dev-…
fa313ab 
…PR85
@grantfirl
Merge branch 'main' into ufs-dev-PR85
d6ac12b
@grantfirl
Copy link
Collaborator Author

ufs-community#1812 changes the following RTs:

1:138:Test 001 cpld_control_p8_mixedmode_intel FAIL
2:209:Test 002 cpld_control_gfsv17_intel FAIL
3:281:Test 003 cpld_control_p8_intel FAIL
4:353:Test 005 cpld_control_qr_p8_intel FAIL
5:413:Test 007 cpld_2threads_p8_intel FAIL
6:473:Test 008 cpld_decomp_p8_intel FAIL
7:533:Test 009 cpld_mpi_p8_intel FAIL
8:605:Test 010 cpld_control_ciceC_p8_intel FAIL
9:665:Test 011 cpld_control_c192_p8_intel FAIL
10:720:Test 013 cpld_bmark_p8_intel FAIL
11:791:Test 015 cpld_control_noaero_p8_intel FAIL
12:860:Test 016 cpld_control_nowave_noaero_p8_intel FAIL
13:920:Test 017 cpld_debug_p8_intel FAIL
14:979:Test 018 cpld_debug_noaero_p8_intel FAIL
15:1105:Test 020 cpld_control_c48_intel FAIL
16:1107:Test 021 cpld_warmstart_c48_intel FAIL
17:1179:Test 023 cpld_control_p8_faster_intel FAIL
18:1250:Test 024 cpld_control_pdlib_p8_intel FAIL
19:1309:Test 027 cpld_debug_pdlib_p8_intel FAIL
24:7117:Test 234 cpld_control_p8_gnu FAIL
25:7186:Test 235 cpld_control_nowave_noaero_p8_gnu FAIL
26:7246:Test 236 cpld_debug_p8_gnu FAIL
27:7317:Test 237 cpld_control_pdlib_p8_gnu FAIL
28:7376:Test 238 cpld_debug_pdlib_p8_gnu FAIL
Four hafs tests fail because the special (fill) value in the mediator files is no longer being scaled by rtime prior to export by ATM

20:4203:Test 134 hafs_regional_atm_ocn_intel FAIL
21:4237:Test 136 hafs_regional_atm_ocn_wav_intel FAIL
22:4739:Test 151 hafs_regional_docn_intel FAIL
23:4754:Test 152 hafs_regional_docn_oisst_intel FAIL
For the hafs tests, all files are B4B except for

957:rt_134_hafs_regional_atm_ocn_intel.log:9: Comparing ufs.hafs.cpl.hi.2019-08-29-21600.nc ............ALT CHECK......NOT OK
958:rt_134_hafs_regional_atm_ocn_intel.log:10: Comparing ufs.hafs.cpl.r.2019-08-29-21600.nc ............ALT CHECK......NOT OK
959:rt_136_hafs_regional_atm_ocn_wav_intel.log:12: Comparing ufs.hafs.cpl.r.2019-08-29-21600.nc ............ALT CHECK......NOT OK
960:rt_151_hafs_regional_docn_intel.log:7: Comparing ufs.hafs.cpl.hi.2019-08-29-21600.nc ............ALT CHECK......NOT OK
961:rt_151_hafs_regional_docn_intel.log:8: Comparing ufs.hafs.cpl.r.2019-08-29-21600.nc ............ALT CHECK......NOT OK
962:rt_152_hafs_regional_docn_oisst_intel.log:7: Comparing ufs.hafs.cpl.hi.2019-08-29-21600.nc ............ALT CHECK......NOT OK
963:rt_152_hafs_regional_docn_oisst_intel.log:8: Comparing ufs.hafs.cpl.r.2019-08-29-21600.nc ............ALT CHECK......NOT OK

@grantfirl
Copy link
Collaborator Author

Also, there are new regression tests for 32-bit physics in RRFS for ufs-community#1797

@grantfirl
Copy link
Collaborator Author

Associated PRs:
#104
NCAR/fv3atm#100
NCAR/ccpp-physics#1029
NCAR/ccpp-scm#399

This was referenced Sep 13, 2023
Merged
Merged
Merged
@grantfirl
Copy link
Collaborator Author

A few Cheyenne tests failed due to a known HDF5 issue, so the log was not updated.

@grantfirl grantfirl merged commit 8f1fd1d into NCAR:main Oct 3, 2023
@mkavulich mkavulich mentioned this pull request Oct 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkavulich mkavulich mkavulich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grantfirl @mkavulich @DeniseWorthen @SamuelTrahanNOAA