Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to apply non-local momentum flux #256

Merged
merged 15 commits into from
Sep 8, 2023

Conversation

gustavo-marques
Copy link
Collaborator

@gustavo-marques gustavo-marques commented Aug 30, 2023

On behalf of Bill Large.
This PR adds the option to apply non-local momentum flux throughout the surface boundary layer. This is done when the local shear is not aligned with the wind. The scheme adds non-local momentum flux in the direction of the wind. To enable this option set FPMIX=True. Additional details on this scheme can be found at http://journals.ametsoc.org/doi/abs/10.1175/JPO-D-18-0066.1

Replaces LU_pred to L_diag, since now this logical only controls
if diagnostics should be posted.
This commit adds the latest updates to the vertFPmix subroutine
after Bill Large did some cleaning. We have highlight places in
the code where work must be done.
omega_w2x is the counter-clockwise angle of the wind stress with
respect to the horizontal abscissa (x-coordinate) at tracer
points [rad]. This variable is needed in the vertPFmix subroutine.
This line of code was lost during the last merge.
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +9.12% 🎉

Comparison is base (d4aa108) 38.04% compared to head (3ea84ff) 47.16%.

❗ Current head 3ea84ff differs from pull request most recent head 65ac638. Consider uploading reports for the commit 65ac638 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           dev/ncar     #256      +/-   ##
============================================
+ Coverage     38.04%   47.16%   +9.12%     
============================================
  Files           269       41     -228     
  Lines         76872     4575   -72297     
  Branches      14125      805   -13320     
============================================
- Hits          29243     2158   -27085     
+ Misses        42356     2236   -40120     
+ Partials       5273      181    -5092     

see 254 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alperaltuntas
Copy link
Member

@gustavo-marques Is this PR ready for review and testing?

@gustavo-marques
Copy link
Collaborator Author

@alperaltuntas; yes, it is. Thanks!

@alperaltuntas alperaltuntas merged commit 8fd5104 into NCAR:dev/ncar Sep 8, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants