Add option to apply non-local momentum flux #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces LU_pred to L_diag, since now this logical only controls if diagnostics should be posted.
This commit adds the latest updates to the vertFPmix subroutine after Bill Large did some cleaning. We have highlight places in the code where work must be done.
omega_w2x is the counter-clockwise angle of the wind stress with respect to the horizontal abscissa (x-coordinate) at tracer points [rad]. This variable is needed in the vertPFmix subroutine.
This line of code was lost during the last merge.
…ix_draft_18April2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## dev/ncar #256 +/- ##
============================================
+ Coverage 38.04% 47.16% +9.12%
============================================
Files 269 41 -228
Lines 76872 4575 -72297
Branches 14125 805 -13320
============================================
- Hits 29243 2158 -27085
+ Misses 42356 2236 -40120
+ Partials 5273 181 -5092 ☔ View full report in Codecov by Sentry. |
|
@gustavo-marques Is this PR ready for review and testing? |
|
@alperaltuntas; yes, it is. Thanks! |
alperaltuntas
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On behalf of Bill Large.
This PR adds the option to apply non-local momentum flux throughout the surface boundary layer. This is done when the local shear is not aligned with the wind. The scheme adds non-local momentum flux in the direction of the wind. To enable this option set
FPMIX=True. Additional details on this scheme can be found at http://journals.ametsoc.org/doi/abs/10.1175/JPO-D-18-0066.1