Pass wavebands from coupler to wave_parameters_CS #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces LU_pred to L_diag, since now this logical only controls if diagnostics should be posted.
This commit adds the latest updates to the vertFPmix subroutine after Bill Large did some cleaning. We have highlight places in the code where work must be done.
omega_w2x is the counter-clockwise angle of the wind stress with respect to the horizontal abscissa (x-coordinate) at tracer points [rad]. This variable is needed in the vertPFmix subroutine.
This line of code was lost during the last merge.
…ix_draft_18April2023
This commit passes the waveband information recieved from the coupler to wave_parameters_CS. This information is set to public so that it can be used elsewhere. To exercise this code the following must be set: SURFBAND = COUPLER WAVE_METHOD = SURFACE_BANDS No answer changes.
|
Please evaluate #256 before this PR. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev/ncar #255 +/- ##
============================================
- Coverage 38.04% 37.90% -0.14%
============================================
Files 269 269
Lines 76872 77176 +304
Branches 14125 14170 +45
============================================
+ Hits 29243 29256 +13
- Misses 42356 42641 +285
- Partials 5273 5279 +6
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
alperaltuntas
approved these changes
Sep 8, 2023
alperaltuntas
pushed a commit
to alperaltuntas/MOM6
that referenced
this pull request
Sep 15, 2023
.testing: Fix concurrency errors in tc4 rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On behalf of Bill Large.
This commit passes the waveband information received from the coupler to wave_parameters_CS. This information is set to public so that it can be used elsewhere. To exercise this code the following must be set:
SURFBAND = COUPLER
WAVE_METHOD = SURFACE_BANDS
No answer changes.