Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

16.1.1 #324

Closed
wants to merge 2 commits into from
Closed

16.1.1 #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d539d0
16.1.1
invalid-email-address May 30, 2024
069748d
update changelog
legobeat May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [16.1.1]

### Changed

- Change provider RPC error log severity from `error` to `warn` ([#323](https://github.com/MetaMask/providers/pull/323))

### Fixed

- Change webextension-polyfill from dependency to peerDependency ([#319](https://github.com/MetaMask/providers/pull/319))
- Users are now expected to have the polyfill in their environment
Comment on lines +18 to +19
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could technically be seen as breaking change, since you now have to install an extra dependency? Not sure if we should major bump though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going a bit back and forth on it. I think in this specific case, it can kind of be assumed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@metamask/providers is used outside of an extension context in some places like Snaps, so I'm not sure we can or should assume the polyfill is installed. 🤔 Is it a required dependency? Can we make it an optional peer dependency instead?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, considering that, might as well play it conservative and go for major, I guess. Reopening.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


## [16.1.0]

### Added
Expand Down Expand Up @@ -392,7 +403,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
added deprecation warnings for them ([#30](https://github.com/MetaMask/providers/pull/30))
- Un-deprecated `sendAsync` ([#29](https://github.com/MetaMask/providers/pull/29))

[Unreleased]: https://github.com/MetaMask/providers/compare/v16.1.0...HEAD
[Unreleased]: https://github.com/MetaMask/providers/compare/v16.1.1...HEAD
[16.1.1]: https://github.com/MetaMask/providers/compare/v16.1.0...v16.1.1
[16.1.0]: https://github.com/MetaMask/providers/compare/v16.0.0...v16.1.0
[16.0.0]: https://github.com/MetaMask/providers/compare/v15.0.0...v16.0.0
[15.0.0]: https://github.com/MetaMask/providers/compare/v14.0.2...v15.0.0
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@metamask/providers",
"version": "16.1.0",
"version": "16.1.1",
"description": "A JavaScript Ethereum provider that connects to the wallet over a stream",
"keywords": [
"MetaMask",
Expand Down
Loading