16.1.1 #324
Closed
16.1.1 #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
legobeat
requested review from
FrederikBolding,
Mrtenz,
rekmarks,
jiexi,
adonesky1,
mcmire and
kumavis
Mrtenz
approved these changes
May 30, 2024
Comment on lines
+18
to
+19
| - Change webextension-polyfill from dependency to peerDependency ([#319](https://github.com/MetaMask/providers/pull/319)) | ||
| - Users are now expected to have the polyfill in their environment |
There was a problem hiding this comment.
This could technically be seen as breaking change, since you now have to install an extra dependency? Not sure if we should major bump though.
There was a problem hiding this comment.
I was going a bit back and forth on it. I think in this specific case, it can kind of be assumed?
There was a problem hiding this comment.
@metamask/providers is used outside of an extension context in some places like Snaps, so I'm not sure we can or should assume the polyfill is installed. 🤔 Is it a required dependency? Can we make it an optional peer dependency instead?
There was a problem hiding this comment.
Hmm, considering that, might as well play it conservative and go for major, I guess. Reopening.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the release candidate for version 16.1.1.