Add MIP for eth_sign discontinuation #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an initial MIP for eth_sign deprecation
adonesky1
reviewed
May 15, 2024
adonesky1
reviewed
May 15, 2024
adonesky1
reviewed
May 15, 2024
Co-authored-by: Alex Donesky <[email protected]>
Adjust the description in the Motivation section. Co-authored-by: Alex Donesky <[email protected]>
Update language to be about discontinuation because the method had already been considered deprecated last year.
vandan
changed the title
Adds a link back to docs with coverage of the alternative signing methods.
2 tasks
shanejonas
reviewed
May 22, 2024
shanejonas
reviewed
May 22, 2024
Update with a more descriptive explanation. Co-authored-by: Shane <[email protected]>
Highlight the potential for future risks Co-authored-by: Shane <[email protected]>
shanejonas
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an initial MIP for eth_sign discontinuation