-
-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document eth_sign discontinuation #1319
Conversation
Preview published: 1313-eth-sign-discontinuation |
Only thought is to try and add a reference to the associated MIP for this change. |
Preview published: 1313-eth-sign-discontinuation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added in a link for MIP-3, but the file is not ready due to autonumbering issues: https://github.com/MetaMask/metamask-improvement-proposals/blob/main/MIPs/mip-x.md. Once that file is updated to |
Preview published: 1313-eth-sign-discontinuation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
Description
Update
eth_sign
description to note that it is no longer supported.Issue(s) fixed
Fixes #1313
Preview
https://docs.metamask.io/1313-eth-sign-discontinuation/wallet/concepts/signing-methods/#eth_sign
Checklist
Complete this checklist before merging your PR: